Skip to content

Commit e02ed86

Browse files
authored
Merge pull request #2623 from aarongreig/aaron/documentFixtures
Document CTS fixtures and macros.
2 parents 010dc4a + 00d8e1a commit e02ed86

File tree

192 files changed

+452
-369
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

192 files changed

+452
-369
lines changed

test/adapters/cuda/context_tests.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#include <thread>
1212

1313
using cudaUrContextCreateTest = uur::urDeviceTest;
14-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(cudaUrContextCreateTest);
14+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(cudaUrContextCreateTest);
1515

1616
constexpr unsigned int known_cuda_api_version = 3020;
1717

test/adapters/cuda/event_tests.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#include "raii.h"
1111

1212
using cudaEventTest = uur::urContextTest;
13-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(cudaEventTest);
13+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(cudaEventTest);
1414

1515
// Testing the urEventGetInfo behaviour for natively constructed (Cuda) events.
1616
// Backend interop APIs can lead to creating event objects that are not fully

test/adapters/cuda/kernel_tests.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
#include "uur/raii.h"
1010

1111
using cudaKernelTest = uur::urQueueTest;
12-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(cudaKernelTest);
12+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(cudaKernelTest);
1313

1414
// The first argument stores the implicit global offset
1515
inline constexpr size_t NumberOfImplicitArgsCUDA = 1;

test/adapters/cuda/memory_tests.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include "uur/raii.h"
99

1010
using cudaMemoryTest = uur::urContextTest;
11-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(cudaMemoryTest);
11+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(cudaMemoryTest);
1212

1313
TEST_P(cudaMemoryTest, urMemBufferNoActiveContext) {
1414
constexpr size_t memSize = 1024u;

test/adapters/cuda/urContextGetNativeHandle.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include "fixtures.h"
88

99
using urCudaContextGetNativeHandle = uur::urContextTest;
10-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urCudaContextGetNativeHandle);
10+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urCudaContextGetNativeHandle);
1111

1212
TEST_P(urCudaContextGetNativeHandle, Success) {
1313
ur_native_handle_t native_context = 0;

test/adapters/cuda/urDeviceCreateWithNativeHandle.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include "fixtures.h"
88

99
using urCudaDeviceCreateWithNativeHandle = uur::urPlatformTest;
10-
UUR_INSTANTIATE_PLATFORM_TEST_SUITE_P(urCudaDeviceCreateWithNativeHandle);
10+
UUR_INSTANTIATE_PLATFORM_TEST_SUITE(urCudaDeviceCreateWithNativeHandle);
1111

1212
TEST_P(urCudaDeviceCreateWithNativeHandle, Success) {
1313
// get a device from cuda

test/adapters/cuda/urDeviceGetNativeHandle.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include "fixtures.h"
88

99
using urCudaGetDeviceNativeHandle = uur::urDeviceTest;
10-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urCudaGetDeviceNativeHandle);
10+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urCudaGetDeviceNativeHandle);
1111

1212
TEST_P(urCudaGetDeviceNativeHandle, Success) {
1313
ur_native_handle_t native_handle;

test/adapters/cuda/urEventCreateWithNativeHandle.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include "raii.h"
99

1010
using urCudaEventCreateWithNativeHandleTest = uur::urQueueTest;
11-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urCudaEventCreateWithNativeHandleTest);
11+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urCudaEventCreateWithNativeHandleTest);
1212

1313
TEST_P(urCudaEventCreateWithNativeHandleTest, Success) {
1414
RAIICUevent cuda_event;

test/adapters/cuda/urEventGetNativeHandle.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include "uur/raii.h"
99

1010
using urCudaEventGetNativeHandleTest = uur::urQueueTest;
11-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urCudaEventGetNativeHandleTest);
11+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urCudaEventGetNativeHandleTest);
1212

1313
TEST_P(urCudaEventGetNativeHandleTest, Success) {
1414
constexpr size_t buffer_size = 1024;

test/adapters/cuda/urQueueGetNativeHandle.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include "queue.hpp"
99

1010
using urCudaQueueGetNativeHandleTest = uur::urQueueTest;
11-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urCudaQueueGetNativeHandleTest);
11+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urCudaQueueGetNativeHandleTest);
1212

1313
TEST_P(urCudaQueueGetNativeHandleTest, Success) {
1414
CUstream Stream;

test/adapters/hip/test_context.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
#include "uur/raii.h"
1313

1414
using urHipContextTest = uur::urDeviceTest;
15-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urHipContextTest);
15+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urHipContextTest);
1616

1717
TEST_P(urHipContextTest, ActiveContexts) {
1818
uur::raii::Context context = nullptr;

test/adapters/hip/test_event.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ struct RAIIHipEvent {
2525
};
2626

2727
using urHipEventTest = uur::urContextTest;
28-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urHipEventTest);
28+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urHipEventTest);
2929

3030
// Testing the urEventGetInfo behaviour for natively constructed (HIP) events.
3131
// Backend interop APIs can lead to creating event objects that are not fully

test/adapters/hip/urContextGetNativeHandle.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include "fixtures.h"
88

99
using urHipContextGetNativeHandleTest = uur::urContextTest;
10-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urHipContextGetNativeHandleTest);
10+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urHipContextGetNativeHandleTest);
1111

1212
TEST_P(urHipContextGetNativeHandleTest, Success) {
1313
ur_native_handle_t native_context = 0;

test/adapters/hip/urDeviceGetNativeHandle.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include "fixtures.h"
88

99
using urHipGetDeviceNativeHandle = uur::urDeviceTest;
10-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urHipGetDeviceNativeHandle);
10+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urHipGetDeviceNativeHandle);
1111

1212
TEST_P(urHipGetDeviceNativeHandle, Success) {
1313
ur_native_handle_t native_handle;

test/adapters/hip/urEventGetNativeHandle.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include "uur/raii.h"
99

1010
using urHipEventGetNativeHandleTest = uur::urQueueTest;
11-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urHipEventGetNativeHandleTest);
11+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urHipEventGetNativeHandleTest);
1212

1313
TEST_P(urHipEventGetNativeHandleTest, Success) {
1414
constexpr size_t buffer_size = 1024;

test/adapters/level_zero/event_cache_tests.cpp

+15-15
Original file line numberDiff line numberDiff line change
@@ -183,18 +183,18 @@ printFlags(const testing::TestParamInfo<typename T::ParamType> &info) {
183183
return platform_device_name + "__" + str;
184184
}
185185

186-
UUR_DEVICE_TEST_SUITE_P(urEventCacheTest,
187-
::testing::
188-
Combine(
189-
testing::Values(0,
190-
UR_QUEUE_FLAG_DISCARD_EVENTS),
191-
testing::Values(
192-
0,
193-
UR_QUEUE_FLAG_OUT_OF_ORDER_EXEC_MODE_ENABLE),
194-
// TODO: why the test fails with
195-
// UR_QUEUE_FLAG_SUBMISSION_BATCHED?
196-
testing::
197-
Values(UR_QUEUE_FLAG_SUBMISSION_IMMEDIATE /*, UR_QUEUE_FLAG_SUBMISSION_BATCHED */),
198-
testing::Values(
199-
0, UR_QUEUE_FLAG_PROFILING_ENABLE)),
200-
printFlags<urEventCacheTest>);
186+
UUR_DEVICE_TEST_SUITE_WITH_PARAM(urEventCacheTest,
187+
::testing::Combine(
188+
testing::Values(
189+
0, UR_QUEUE_FLAG_DISCARD_EVENTS),
190+
testing::Values(
191+
0,
192+
UR_QUEUE_FLAG_OUT_OF_ORDER_EXEC_MODE_ENABLE),
193+
// TODO: why the test fails with
194+
// UR_QUEUE_FLAG_SUBMISSION_BATCHED?
195+
testing::
196+
Values(
197+
UR_QUEUE_FLAG_SUBMISSION_IMMEDIATE /*, UR_QUEUE_FLAG_SUBMISSION_BATCHED */),
198+
testing::Values(
199+
0, UR_QUEUE_FLAG_PROFILING_ENABLE)),
200+
printFlags<urEventCacheTest>);

test/adapters/level_zero/ipc.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#endif
1414

1515
using urL0IpcTest = uur::urContextTest;
16-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urL0IpcTest);
16+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urL0IpcTest);
1717

1818
TEST_P(urL0IpcTest, SuccessHostL0Ipc) {
1919
ur_device_usm_access_capability_flags_t hostUSMSupport = 0;

test/adapters/level_zero/multi_device_event_cache_tests.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ static std::shared_ptr<_zel_tracer_handle_t> tracer = [] {
2424
}();
2525

2626
using urMultiQueueMultiDeviceEventCacheTest = uur::urAllDevicesTest;
27-
UUR_INSTANTIATE_PLATFORM_TEST_SUITE_P(urMultiQueueMultiDeviceEventCacheTest);
27+
UUR_INSTANTIATE_PLATFORM_TEST_SUITE(urMultiQueueMultiDeviceEventCacheTest);
2828

2929
TEST_P(urMultiQueueMultiDeviceEventCacheTest,
3030
GivenMultiSubDeviceWithQueuePerSubDeviceThenEventIsSharedBetweenQueues) {

test/adapters/level_zero/urEnqueueMemBufferMapHostPtr.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
using urEnqueueMemBufferMapTestWithParamL0 =
1212
uur::urMemBufferQueueTestWithParam<uur::mem_buffer_test_parameters_t>;
1313

14-
UUR_DEVICE_TEST_SUITE_P(
14+
UUR_DEVICE_TEST_SUITE_WITH_PARAM(
1515
urEnqueueMemBufferMapTestWithParamL0,
1616
::testing::ValuesIn(uur::mem_buffer_test_parameters),
1717
uur::printMemBufferTestString<urEnqueueMemBufferMapTestWithParamL0>);

test/adapters/level_zero/urEventCreateWithNativeHandle.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
using namespace std::chrono_literals;
1717
using urLevelZeroEventNativeHandleTest = uur::urQueueTest;
18-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urLevelZeroEventNativeHandleTest);
18+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urLevelZeroEventNativeHandleTest);
1919

2020
#define TEST_MEMCPY_SIZE 4096
2121

test/adapters/level_zero/urKernelCreateWithNativeHandle.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#include <uur/fixtures.h>
1111

1212
using urLevelZeroKernelNativeHandleTest = uur::urQueueTest;
13-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urLevelZeroKernelNativeHandleTest);
13+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urLevelZeroKernelNativeHandleTest);
1414

1515
TEST_P(urLevelZeroKernelNativeHandleTest, OwnedHandleRelease) {
1616
ze_context_handle_t native_context;

test/adapters/level_zero/urProgramLink.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include <uur/fixtures.h>
99

1010
using urLevelZeroProgramLinkTest = uur::urProgramTest;
11-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urLevelZeroProgramLinkTest);
11+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urLevelZeroProgramLinkTest);
1212

1313
TEST_P(urLevelZeroProgramLinkTest, InvalidLinkOptionsPrintedInLog) {
1414
ur_program_handle_t linked_program = nullptr;

test/adapters/level_zero/v2/command_list_cache_test.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
struct CommandListCacheTest : public uur::urContextTest {};
2323

24-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(CommandListCacheTest);
24+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(CommandListCacheTest);
2525

2626
TEST_P(CommandListCacheTest, CanStoreAndRetriveImmediateAndRegularCmdLists) {
2727
v2::command_list_cache_t cache(context->getZeHandle());

test/adapters/level_zero/v2/deferred_kernel.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ struct urEnqueueKernelLaunchTest : uur::urKernelExecutionTest {
2222
size_t global_offset = 0;
2323
size_t n_dimensions = 1;
2424
};
25-
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urEnqueueKernelLaunchTest);
25+
UUR_INSTANTIATE_DEVICE_TEST_SUITE(urEnqueueKernelLaunchTest);
2626

2727
TEST_P(urEnqueueKernelLaunchTest, DeferredKernelRelease) {
2828
ur_mem_handle_t buffer = nullptr;
@@ -111,7 +111,7 @@ struct urMultiQueueLaunchKernelDeferFreeTest
111111
}
112112
};
113113

114-
UUR_INSTANTIATE_PLATFORM_TEST_SUITE_P(urMultiQueueLaunchKernelDeferFreeTest);
114+
UUR_INSTANTIATE_PLATFORM_TEST_SUITE(urMultiQueueLaunchKernelDeferFreeTest);
115115

116116
TEST_P(urMultiQueueLaunchKernelDeferFreeTest, Success) {
117117
auto zeEvent1 = createZeEvent(context, devices[0]);

test/adapters/level_zero/v2/event_pool_test.cpp

+5-4
Original file line numberDiff line numberDiff line change
@@ -147,8 +147,8 @@ static ProviderParams test_cases[] = {
147147
//{TEST_PROVIDER_COUNTER, EVENT_COUNTER, QUEUE_IMMEDIATE},
148148
};
149149

150-
UUR_DEVICE_TEST_SUITE_P(EventPoolTest, testing::ValuesIn(test_cases),
151-
printParams<EventPoolTest>);
150+
UUR_DEVICE_TEST_SUITE_WITH_PARAM(EventPoolTest, testing::ValuesIn(test_cases),
151+
printParams<EventPoolTest>);
152152

153153
TEST_P(EventPoolTest, InvalidDevice) {
154154
auto pool = cache->borrow(MAX_DEVICES, getParam().flags);
@@ -240,8 +240,9 @@ TEST_P(EventPoolTest, ProviderNormalUseMostFreePool) {
240240

241241
using EventPoolTestWithQueue = uur::urQueueTestWithParam<ProviderParams>;
242242

243-
UUR_DEVICE_TEST_SUITE_P(EventPoolTestWithQueue, testing::ValuesIn(test_cases),
244-
printParams<EventPoolTest>);
243+
UUR_DEVICE_TEST_SUITE_WITH_PARAM(EventPoolTestWithQueue,
244+
testing::ValuesIn(test_cases),
245+
printParams<EventPoolTest>);
245246

246247
// TODO: actual min version is unknown, retest after drivers on CI are
247248
// updated.

test/adapters/level_zero/v2/memory_residency.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include "uur/utils.h"
99

1010
using urMemoryResidencyTest = uur::urMultiDeviceContextTestTemplate<1>;
11-
UUR_INSTANTIATE_PLATFORM_TEST_SUITE_P(urMemoryResidencyTest);
11+
UUR_INSTANTIATE_PLATFORM_TEST_SUITE(urMemoryResidencyTest);
1212

1313
TEST_P(urMemoryResidencyTest, allocatingDeviceMemoryWillResultInOOM) {
1414
static constexpr size_t allocSize = 1024 * 1024;

test/conformance/README.md

+79
Original file line numberDiff line numberDiff line change
@@ -70,3 +70,82 @@ The following adapter matcher objects are available:
7070
* `uur::CUDA`
7171
* `uur::HIP`
7272
* `uur::NativeCPU`
73+
74+
## Writing a new CTS test
75+
76+
If you're writing a new CTS test you'll need to make use of the existing test
77+
fixtures and instantiation macros to access the adapters available for testing.
78+
The definitions for these can all be found in
79+
[fixtures.h](https://github.com/oneapi-src/unified-runtime/blob/main/test/conformance/testing/include/uur/fixtures.h).
80+
81+
There are five "base" fixtures in that header that each correspond to an
82+
instantiation macro - specific macros are needed due to how gtest handles
83+
parameterization and printing. All of these make use of gtest's [value
84+
parameterization](http://google.github.io/googletest/advanced.html#how-to-write-value-parameterized-tests)
85+
to instantiate the tests for all the available backends. Two of the five base
86+
fixtures have a wrapper to allow for tests defining their own parameterization.
87+
88+
The base fixtures and their macros are detailed below. Tests inheriting from
89+
fixtures other than the base ones (`urContextTest`, etc.) must be instantiated
90+
with the macro that corresponds to whatever base class is ultimately being
91+
inherited from. In the case of `urContextTest` we can see that it inherits
92+
directly from `urDeviceTest`, so we should use the `urDeviceTest` macro. For
93+
other fixtures you'll need to follow the inheritance back a few steps to figure
94+
it out.
95+
96+
### `urAdapterTest`
97+
98+
This fixture is intended for tests that will be run once for each adapter
99+
available. The only data member it provides is a `ur_adapter_handle_t`.
100+
101+
Instantiated with the `UUR_INSTANTIATE_ADAPTER_TEST_SUITE` macro.
102+
103+
### `urPlatformTest`
104+
105+
This fixture is intended for tests that will be run once for each platform
106+
available (note the potentially one-to-many relationship between adapters and
107+
platforms). The only data member it provides is a `ur_platform_handle_t`.
108+
109+
Instantiated with the `UUR_INSTANTIATE_PLATFORM_TEST_SUITE` macro.
110+
111+
### `urDeviceTest`
112+
113+
This fixture is intended for tests that will be run once for each device
114+
available. It provides a `ur_adapter_handle_t`, `ur_platform_handle_t` and a
115+
`ur_device_handle_t` (the former two corresponding to the latter).
116+
117+
Instantiated with the `UUR_INSTANTIATE_DEVICE_TEST_SUITE` macro.
118+
119+
### `urPlatformTestWithParam`
120+
121+
This fixture functions the same as `urPlatformTest` except it allows value
122+
parameterization via a template parameter. Note the parameter you specify is
123+
accessed with `getParam()` rather than gtest's `GetParam()`. A platform handle
124+
is provided the same way it is in the non-parameterized variant.
125+
126+
Instantiated with the `UUR_PLATFORM_TEST_SUITE_WITH_PARAM` macro, which, in
127+
addition to the fixture, takes a `::testing::Values` list of parameter values
128+
and a printer (more detail about that below).
129+
130+
### `urDeviceTestWithParam`
131+
132+
As with the parameterized platform fixture this functions identically to
133+
`urDeviceTest` with the addition of the template parameter for
134+
parameterization.
135+
136+
Instantiated with the `UUR_DEVICE_TEST_SUITE_WITH_PARAM` macro.
137+
138+
### Parameter printers
139+
140+
When instantiating tests based on the parameterized fixtures you need to
141+
provide a printer function along with the value list. This determines how the
142+
parameter values are incorporated into the test name. If your parameter type
143+
has a `<<` operator defined for it, you can simply use the
144+
`platformTestWithParamPrinter`/`deviceTestWithParamPrinter` helper functions for
145+
this.
146+
147+
If you find yourself needing to write a custom printer function, bear in mind
148+
that due to the parameterization wrapper it'll need to deal with a tuple
149+
containing the platform/device information and your parameter. You should
150+
reference the implementations of `platformTestWithParamPrinter` and
151+
`deviceTestWithParamPrinter` to see how this is handled.

test/conformance/adapter/urAdapterGetInfo.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
using urAdapterGetInfoTest = uur::urAdapterTest;
1212

13-
UUR_INSTANTIATE_ADAPTER_TEST_SUITE_P(urAdapterGetInfoTest);
13+
UUR_INSTANTIATE_ADAPTER_TEST_SUITE(urAdapterGetInfoTest);
1414

1515
TEST_P(urAdapterGetInfoTest, SuccessBackend) {
1616
ur_adapter_info_t property_name = UR_ADAPTER_INFO_BACKEND;

test/conformance/adapter/urAdapterGetLastError.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ struct urAdapterGetLastErrorTest : uur::urAdapterTest {
1111
const char *message = nullptr;
1212
};
1313

14-
UUR_INSTANTIATE_ADAPTER_TEST_SUITE_P(urAdapterGetLastErrorTest);
14+
UUR_INSTANTIATE_ADAPTER_TEST_SUITE(urAdapterGetLastErrorTest);
1515

1616
TEST_P(urAdapterGetLastErrorTest, Success) {
1717
// We can't reliably generate a UR_RESULT_ERROR_ADAPTER_SPECIFIC error to

test/conformance/adapter/urAdapterRelease.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include <uur/fixtures.h>
88

99
using urAdapterReleaseTest = uur::urAdapterTest;
10-
UUR_INSTANTIATE_ADAPTER_TEST_SUITE_P(urAdapterReleaseTest);
10+
UUR_INSTANTIATE_ADAPTER_TEST_SUITE(urAdapterReleaseTest);
1111

1212
TEST_P(urAdapterReleaseTest, Success) {
1313
uint32_t referenceCountBefore = 0;

0 commit comments

Comments
 (0)