You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[SYCL] Default-initialize UR structs used in handler_impl (#14885)
The C-style structs used by the `handler_impl` for bindless images are
not initialized. Although their values get initialized later in
execution, when it is decided this information is actually used, leaving
these values uninitialized still leave the possibility of
vulnerabilities. This PR initializes them.
I'd like to bring attention to the fact that we could also use
`std::optional` here, although that'll increase the size used for each
field here. Zero initializing these structs is also an option, although
I noticed many of these structs have default values, so I default
initialized instead. If `std::optional` or zero initializing would be a
better option here, please let me know and I'll make the changes.
Thanks!
0 commit comments