Skip to content

Commit ebbd568

Browse files
authored
[SYCL][HIP] Add missing check-sycl-hip skips (#4549)
These match CUDA plugin skips. The `KernelID` and `assert` tests use SPIRV binaries which are not supported by the HIP plugin. The `bfloat16` extension is also not yet supported by the HIP plugin.
1 parent 8aa3513 commit ebbd568

File tree

3 files changed

+21
-1
lines changed

3 files changed

+21
-1
lines changed

sycl/test/extensions/bfloat16.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
// RUN: %clangxx -fsycl-device-only -fsycl-targets=%sycl_triple -S %s -o - | FileCheck %s
22

3-
// UNSUPPORTED: cuda
3+
// UNSUPPORTED: cuda || hip_amd
44

55
#include <sycl/ext/intel/experimental/bfloat16.hpp>
66
#include <sycl/sycl.hpp>

sycl/unittests/SYCL2020/KernelID.cpp

+15
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,11 @@ TEST(KernelID, FreeKernelIDEqualsKernelBundleId) {
118118
return;
119119
}
120120

121+
if (Plt.get_backend() == sycl::backend::hip) {
122+
std::cout << "Test is not supported on HIP platform, skipping\n";
123+
return;
124+
}
125+
121126
sycl::unittest::PiMock Mock{Plt};
122127
setupDefaultMockAPIs(Mock);
123128

@@ -156,6 +161,11 @@ TEST(KernelID, KernelBundleKernelIDsIntersectAll) {
156161
return;
157162
}
158163

164+
if (Plt.get_backend() == sycl::backend::hip) {
165+
std::cout << "Test is not supported on HIP platform, skipping\n";
166+
return;
167+
}
168+
159169
sycl::unittest::PiMock Mock{Plt};
160170
setupDefaultMockAPIs(Mock);
161171

@@ -190,6 +200,11 @@ TEST(KernelID, KernelIDHasKernel) {
190200
return;
191201
}
192202

203+
if (Plt.get_backend() == sycl::backend::hip) {
204+
std::cout << "Test is not supported on HIP platform, skipping\n";
205+
return;
206+
}
207+
193208
sycl::unittest::PiMock Mock{Plt};
194209
setupDefaultMockAPIs(Mock);
195210

sycl/unittests/assert/assert.cpp

+5
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,11 @@ TEST(Assert, TestPositive) {
366366
printf("Test is not supported on CUDA platform, skipping\n");
367367
return;
368368
}
369+
370+
if (Plt.get_backend() == sycl::backend::hip) {
371+
printf("Test is not supported on HIP platform, skipping\n");
372+
return;
373+
}
369374
}
370375

371376
#ifndef _WIN32

0 commit comments

Comments
 (0)