Skip to content

Commit f739a6d

Browse files
sarnexsarnex
authored
[SYCL][ESIMD][E2E] Reenable some gather and scatter tests (#13881)
Issue was fixed in the driver, manual testing using the flaky test script shows no issues. Signed-off-by: Sarnie, Nick <[email protected]>
1 parent 16007fa commit f739a6d

File tree

2 files changed

+16
-34
lines changed

2 files changed

+16
-34
lines changed

‎sycl/test-e2e/ESIMD/unified_memory_api/Inputs/gather.hpp

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -452,10 +452,8 @@ template <typename T, TestFeatures Features> bool testUSM(queue Q) {
452452

453453
// Check VS > 1. GPU supports only dwords and qwords in this mode.
454454
if constexpr (sizeof(T) >= 4) {
455-
// TODO: This test case causes flaky fail. Enable it after the issue
456-
// in GPU driver is fixed.
457-
// Passed &= testUSM<T, 16, 2, UseMask, !UsePassThru, UseProperties>(
458-
// Q, 3, AlignElemProps);
455+
Passed &= testUSM<T, 16, 2, UseMask, !UsePassThru, UseProperties>(
456+
Q, 3, AlignElemProps);
459457

460458
Passed &= testUSM<T, 32, 2, !UseMask, !UsePassThru, UseProperties>(
461459
Q, 3, AlignElemProps);
@@ -690,10 +688,8 @@ template <typename T, TestFeatures Features> bool testSLM(queue Q) {
690688

691689
// Check VS > 1. GPU supports only dwords and qwords in this mode.
692690
if constexpr (sizeof(T) >= 4) {
693-
// TODO: This test case causes flaky fail. Enable it after the issue
694-
// in GPU driver is fixed.
695-
// Passed &= testUSM<T, 16, 2, UseMask, !UsePassThru, UseProperties>(
696-
// Q, 3, AlignElemProps);
691+
Passed &= testUSM<T, 16, 2, UseMask, !UsePassThru, UseProperties>(
692+
Q, 3, AlignElemProps);
697693

698694
Passed &= testSLM<T, 32, 2, !UseMask, !UsePassThru, UseProperties>(
699695
Q, 3, AlignElemProps);
@@ -746,10 +742,8 @@ template <typename T, TestFeatures Features> bool testACC(queue Q) {
746742

747743
// Check VS > 1. GPU supports only dwords and qwords in this mode.
748744
if constexpr (sizeof(T) >= 4) {
749-
// TODO: This test case causes flaky fail. Enable it after the issue
750-
// in GPU driver is fixed.
751-
// Passed &= testACC<T, 16, 2, UseMask, !UsePassThru, UseProperties>(
752-
// Q, 3, AlignElemProps);
745+
Passed &= testACC<T, 16, 2, UseMask, !UsePassThru, UseProperties>(
746+
Q, 3, AlignElemProps);
753747

754748
Passed &= testACC<T, 32, 2, !UseMask, !UsePassThru, UseProperties>(
755749
Q, 3, AlignElemProps);
@@ -996,11 +990,8 @@ template <typename T, TestFeatures Features> bool testLACC(queue Q) {
996990

997991
// Check VS > 1. GPU supports only dwords and qwords in this mode.
998992
if constexpr (sizeof(T) >= 4) {
999-
// TODO: This test case causes flaky fail. Enable it after the issue
1000-
// in GPU driver is fixed.
1001-
// Passed &= testACC<T, 16, 2, UseMask, !UsePassThru, UseProperties>(
1002-
// Q, 3, AlignElemProps);
1003-
993+
Passed &= testACC<T, 16, 2, UseMask, !UsePassThru, UseProperties>(
994+
Q, 3, AlignElemProps);
1004995
Passed &= testLACC<T, 32, 2, !UseMask, !UsePassThru, UseProperties>(
1005996
Q, 3, AlignElemProps);
1006997
Passed &= testLACC<T, 32, 2, UseMask, !UsePassThru, UseProperties>(

‎sycl/test-e2e/ESIMD/unified_memory_api/Inputs/scatter.hpp

Lines changed: 8 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -518,10 +518,8 @@ template <typename T, TestFeatures Features> bool testUSM(queue Q) {
518518

519519
// Check VS > 1. GPU supports only dwords and qwords in this mode.
520520
if constexpr (sizeof(T) >= 4) {
521-
// TODO: This test case causes flaky fail. Enable it after the issue
522-
// in GPU driver is fixed.
523-
// Passed &=
524-
// testUSM<T, 16, 2, CheckMask, CheckProperties>(Q, 2, AlignElemProps)
521+
Passed &=
522+
testUSM<T, 16, 2, CheckMask, CheckProperties>(Q, 2, AlignElemProps);
525523
Passed &=
526524
testUSM<T, 32, 2, !CheckMask, CheckProperties>(Q, 2, AlignElemProps);
527525
Passed &=
@@ -575,10 +573,8 @@ template <typename T, TestFeatures Features> bool testACC(queue Q) {
575573

576574
// Check VS > 1. GPU supports only dwords and qwords in this mode.
577575
if constexpr (sizeof(T) >= 4) {
578-
// TODO: This test case causes flaky fail. Enable it after the issue
579-
// in GPU driver is fixed.
580-
// Passed &=
581-
// testACC<T, 16, 2, CheckMask, CheckProperties>(Q, 2, AlignElemProps)
576+
Passed &=
577+
testACC<T, 16, 2, CheckMask, CheckProperties>(Q, 2, AlignElemProps);
582578
Passed &=
583579
testACC<T, 32, 2, !CheckMask, CheckProperties>(Q, 2, AlignElemProps);
584580
Passed &=
@@ -630,10 +626,8 @@ template <typename T, TestFeatures Features> bool testSLM(queue Q) {
630626

631627
// Check VS > 1. GPU supports only dwords and qwords in this mode.
632628
if constexpr (sizeof(T) >= 4) {
633-
// TODO: This test case causes flaky fail. Enable it after the issue
634-
// in GPU driver is fixed.
635-
// Passed &=
636-
// testSLM<T, 16, 2, CheckMask, CheckProperties>(Q, 2, AlignElemProps)
629+
Passed &=
630+
testSLM<T, 16, 2, CheckMask, CheckProperties>(Q, 2, AlignElemProps);
637631
Passed &=
638632
testSLM<T, 32, 2, !CheckMask, CheckProperties>(Q, 2, AlignElemProps);
639633
Passed &=
@@ -853,11 +847,8 @@ template <typename T, TestFeatures Features> bool testLACC(queue Q) {
853847

854848
// Check VS > 1. GPU supports only dwords and qwords in this mode.
855849
if constexpr (sizeof(T) >= 4) {
856-
// TODO: This test case causes flaky fail. Enable it after the issue
857-
// in GPU driver is fixed.
858-
// Passed &=
859-
// testLACC<T, 16, 2, CheckMask, CheckProperties>(Q, 2,
860-
// AlignElemProps)
850+
Passed &=
851+
testLACC<T, 16, 2, CheckMask, CheckProperties>(Q, 2, AlignElemProps);
861852
Passed &=
862853
testLACC<T, 32, 2, !CheckMask, CheckProperties>(Q, 2, AlignElemProps);
863854
Passed &=

0 commit comments

Comments
 (0)