Skip to content

replace bool with ur_bool_t in sycl/include/sycl/info/device_traits.def and the uses of it. #14919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #14598
aarongreig opened this issue Aug 2, 2024 · 1 comment
Closed
Tracked by #14598

replace bool with ur_bool_t in sycl/include/sycl/info/device_traits.def and the uses of it. #14919

aarongreig opened this issue Aug 2, 2024 · 1 comment
Assignees
@aarongreig
Labels
pi-port

Comments

@aarongreig
Copy link
Contributor

aarongreig commented Aug 2, 2024 •
edited
Loading

created based on this comment chain #14145 (comment)
@aarongreig aarongreig mentioned this issue Aug 2, 2024
Closed
@aarongreig aarongreig self-assigned this Aug 2, 2024
@aarongreig aarongreig changed the title replace bool with ur_bool_t in sycl/include/sycl/info/device_traits.def and the uses of it. mentioned here replace bool with ur_bool_t in sycl/include/sycl/info/device_traits.def and the uses of it. Aug 2, 2024
@aarongreig aarongreig mentioned this issue Aug 2, 2024
Closed
@aarongreig
Copy link
Contributor Author

This change constitutes an ABI break on windows, and there's also an issue wrt sycl spec (see comment on #14921). I don't think it's worth pursuing this any further right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aarongreig aarongreig

Labels
pi-port
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SYCL] Switch device traits to use ur_bool_t instead of bool. aarongreig/intel-llvm
1 participant
@aarongreig