Skip to content

[SYCL] Enable let PragmaAttributeSupport for SYCL attributes #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elizabethandrews opened this issue Dec 18, 2020 · 0 comments · Fixed by #3022
Closed

[SYCL] Enable let PragmaAttributeSupport for SYCL attributes #2910

elizabethandrews opened this issue Dec 18, 2020 · 0 comments · Fixed by #3022
Assignees

Comments

@elizabethandrews
Copy link
Contributor

elizabethandrews commented Dec 18, 2020

The typical upstream expectation is that new attributes are supported via #pragma clang attribute (https://clang.llvm.org/docs/LanguageExtensions.html#specifying-an-attribute-for-multiple-declarations-pragma-clang-attribute) unless there's some reason for them not to (like statement or type attributes).

This does NOT enable pragma spellings for attribute as previously thought and is actually a useful functionality. See comment thread - #2877 (comment) for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant