Skip to content

[Driver] Clang :: Driver/sycl-device-lib.cpp fails if libdevice project is not pre-built #3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bader opened this issue Apr 27, 2021 · 3 comments · Fixed by #3639
Closed
Assignees
Labels
bug Something isn't working

Comments

@bader
Copy link
Contributor

bader commented Apr 27, 2021

Describe the bug
Clang :: Driver/sycl-device-lib.cpp has a dependency on libdevice libraries. It seems to me, that driver schedules different actions based on presence of libdevice libraries. If libraries are missing some actions are skipped, but test passes only if required libraries are present.

To Reproduce
Checkout sycl branch, configure build files and build check-clang target. It's important to not build libdevice target or any other target building libdevice (e.g. check-sycl) before building check-clang.

Environment (please complete the following information):

  • OS: Linux
@bader
Copy link
Contributor Author

bader commented Jun 4, 2021

@jinge90, it looks like the is not fixed. There were two commits recently breaking SYCL project build, which impacted check-clang results. Clang :: Driver/sycl-device-lib.cpp still fails if libdevice project is not built.
Could you take a look, please?
See https://github.com/intel/llvm/runs/2738419633?check_suite_focus=true and https://github.com/intel/llvm/runs/2740297660?check_suite_focus=true for details.

@jinge90
Copy link
Contributor

jinge90 commented Jun 4, 2021

@jinge90, it looks like the is not fixed. There were two commits recently breaking SYCL project build, which impacted check-clang results. Clang :: Driver/sycl-device-lib.cpp still fails if libdevice project is not built.
Could you take a look, please?
See https://github.com/intel/llvm/runs/2738419633?check_suite_focus=true and https://github.com/intel/llvm/runs/2740297660?check_suite_focus=true for details.

Hi, @bader
It looks weird, I just built the latest compiler and removed all libdevice binary, the sycl-device-lib.cpp can still pass with all the libdevice binary removed.
Can I log in the machine to have a look or can anyone provide the file list in compiler library folder from the failed SYCL project?
Thanks very much.

@bader
Copy link
Contributor Author

bader commented Jun 4, 2021

I think this issue should be reproducible from clean state (i.e. when build directory is removed):

  1. run configure.py + check-clang before building other targets.
  2. or maybe make/ninja clean + check-clang will work.

Anyway the steps from post-commit will work if you checkout 70281ea.

Can I log in the machine to have a look or can anyone provide the file list in compiler library folder from the failed SYCL project?

Please, contact @tfzhu or @DoyleLi, if you won't be able to reproduce it locally.

@bader bader closed this as completed Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants