Reduce exposed modules in cardano-api #4546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/cardano-api-refactor-reduce-exposed-modules
branch
from
0b49e5e to
da08513
Compare
Jimbo4350
requested review from
newhoggy,
a team,
deepfire,
denisshevchenko,
jutaro,
dcoutts,
erikd,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
newhoggy
approved these changes
Oct 21, 2022
|
Given that this is a breaking change for downstream users of the API, should there be a note in the changelog about it? |
I would hope so myself! |
|
Yep definitely. I'll update the changelog. |
Jimbo4350
force-pushed
the
jordan/cardano-api-refactor-reduce-exposed-modules
branch
from
6e5d694 to
3e376b3
Compare
Jimbo4350
requested review from
MarcFontaine,
mgmeier,
fmaste and
cleverca22
as code owners
Jimbo4350
force-pushed
the
jordan/cardano-api-refactor-reduce-exposed-modules
branch
from
3e376b3 to
a242326
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 26, 2022
4546: Reduce exposed modules in cardano-api r=Jimbo4350 a=Jimbo4350 Co-authored-by: Jordan Millar <[email protected]>
|
Build failed: |
rather than their resident module
Make Cardano.Api.SerialiseTextEnvelope an internal module
Jimbo4350
force-pushed
the
jordan/cardano-api-refactor-reduce-exposed-modules
branch
from
a242326 to
a822aee
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 31, 2022
4546: Reduce exposed modules in cardano-api r=Jimbo4350 a=Jimbo4350 Co-authored-by: Jordan Millar <[email protected]>
|
Build failed: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 31, 2022
4546: Reduce exposed modules in cardano-api r=Jimbo4350 a=Jimbo4350 Co-authored-by: Jordan Millar <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from MarcFontaine, cleverca22, deepfire, fmaste, jutaro, and/or mgmeier.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
deepfire
approved these changes
Nov 1, 2022
|
bors r+ |
1 similar comment
|
bors r+ |
|
Already running a review |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 1, 2022
4546: Reduce exposed modules in cardano-api r=deepfire a=Jimbo4350 4587: Add Ord instance for AddressInEra r=Jimbo4350 a=Jimbo4350 Co-authored-by: `@UlfNorell` Co-authored-by: Jordan Millar <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from MarcFontaine, cleverca22, deepfire, fmaste, input-output-hk/devops, jutaro, mgmeier, and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
bors r+ |
|
Build succeeded: |
iohk-bors
bot
deleted the
jordan/cardano-api-refactor-reduce-exposed-modules
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.