-
Notifications
You must be signed in to change notification settings - Fork 730
workbench: towards a cloud nomad backend #4760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcf6ff8
to
ed45273
Compare
deepfire
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you a lot @fmaste !
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 10, 2023
4760: workbench: towards a cloud nomad backend r=deepfire a=fmaste Multiple enhancements for the workbench's Nomad backend Moving towards cloud deployments: - Nix generated JSON Nomad job file (previously bash script and HCL) - Using Nomad templates instead of mounting volumes when possible - `node-0` and `generator` in the same container - Using a pinned nomad/podman version - WIP: `oneTracerPerNode` flag - WIP: Stop using Nomad `-dev` mode (Switch to multiple agents) Misc smaller Nix cleanups/refactorings: - Shared read-only genesis folder(even if symlinks, multiple were expected) - Honor the optional tracer flag in `supervisor.conf` - Verbosity for the stop/kill supervisor flags - Configurable loglevel for supervisord inside containers Also: fix `--trace` not working in `cabalRun` mode Co-authored-by: Federico Mastellone <[email protected]>
Build failed: |
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 10, 2023
4760: workbench: towards a cloud nomad backend r=deepfire a=fmaste Multiple enhancements for the workbench's Nomad backend Moving towards cloud deployments: - Nix generated JSON Nomad job file (previously bash script and HCL) - Using Nomad templates instead of mounting volumes when possible - `node-0` and `generator` in the same container - Using a pinned nomad/podman version - WIP: `oneTracerPerNode` flag - WIP: Stop using Nomad `-dev` mode (Switch to multiple agents) Misc smaller Nix cleanups/refactorings: - Shared read-only genesis folder(even if symlinks, multiple were expected) - Honor the optional tracer flag in `supervisor.conf` - Verbosity for the stop/kill supervisor flags - Configurable loglevel for supervisord inside containers Also: fix `--trace` not working in `cabalRun` mode Co-authored-by: Federico Mastellone <[email protected]>
Build failed: |
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 10, 2023
4760: workbench: towards a cloud nomad backend r=fmaste a=fmaste Multiple enhancements for the workbench's Nomad backend Moving towards cloud deployments: - Nix generated JSON Nomad job file (previously bash script and HCL) - Using Nomad templates instead of mounting volumes when possible - `node-0` and `generator` in the same container - Using a pinned nomad/podman version - WIP: `oneTracerPerNode` flag - WIP: Stop using Nomad `-dev` mode (Switch to multiple agents) Misc smaller Nix cleanups/refactorings: - Shared read-only genesis folder(even if symlinks, multiple were expected) - Honor the optional tracer flag in `supervisor.conf` - Verbosity for the stop/kill supervisor flags - Configurable loglevel for supervisord inside containers Also: fix `--trace` not working in `cabalRun` mode Co-authored-by: Federico Mastellone <[email protected]>
Build failed: |
- supervisor.conf verbosity: show defaults of important options - If a service already finished with a non-zero status, the whole script failed - tracer is optional
No more HCL and other changes towards SRE compatiblity and cloud deployments
Use the meta stanza for default values Use the template stanza to populate folders merge node-0 and generator tasks Use only one genesis folder
The CI is not a regression relative to The workbench changes were tested with |
..and with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple enhancements for the workbench's Nomad backend
Moving towards cloud deployments:
node-0
andgenerator
in the same containeroneTracerPerNode
flag-dev
mode (Switch to multiple agents)Misc smaller Nix cleanups/refactorings:
supervisor.conf
Also: fix
--trace
not working incabalRun
mode