Add event.type to concurrency group #4947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
approved these changes
Mar 7, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
newhoggy
force-pushed
the
newhoggy/add-event-type-to-concurrency-group
branch
from
645351f to
6e89e54
Compare
newhoggy
requested review from
deepfire,
mgmeier,
fmaste,
jutaro,
cleverca22,
a team,
dcoutts,
JaredCorduan and
CarlosLopezDeLara
as code owners
|
I rebased onto #4939 because a flaky test aborted the merge. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because our workflows can be triggered by more than one event type:
pushandmerge_group.When a PR is queued to early after a push, the
merge_groupjob would cancel thepushjob or vice-versa causing unnecessary build failures.