Skip to content

New build-complete job for required checks #4954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2023
Merged

New build-complete job for required checks #4954

merged 1 commit into from
Mar 8, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Mar 8, 2023

No description provided.

@newhoggy newhoggy marked this pull request as ready for review March 8, 2023 06:00
@newhoggy newhoggy requested review from Jimbo4350 and a team as code owners March 8, 2023 06:00
angerman
angerman approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

@angerman angerman added this pull request to the merge queue Mar 8, 2023
@angerman
Copy link
Contributor

angerman commented Mar 8, 2023

I'll change branch protection to build-complete afterwards.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2023
@newhoggy newhoggy force-pushed the newhoggy/new-build-complete-job-for-required-checks branch from 6d2b61e to 4ee935d Compare March 8, 2023 07:41
@angerman angerman enabled auto-merge March 8, 2023 09:09
@angerman angerman force-pushed the newhoggy/new-build-complete-job-for-required-checks branch from 4ee935d to e324dea Compare March 8, 2023 09:23
@angerman
Copy link
Contributor

angerman commented Mar 8, 2023

Finally found the error, very confusing.

The workflow is not valid. .github/workflows/haskell-linux.yml (Line: 188, Col: 13): Job 'build-complete' depends on unknown job 'build'.

For this the GH UI wasn't very straight forward.

@angerman angerman force-pushed the newhoggy/new-build-complete-job-for-required-checks branch from e324dea to 2f3f2ee Compare March 8, 2023 09:28
@angerman angerman added this pull request to the merge queue Mar 8, 2023
Merged via the queue into master with commit 751f22b Mar 8, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/new-build-complete-job-for-required-checks branch March 8, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angerman angerman angerman approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@newhoggy @angerman