Skip to content

🔥 [🐛] NPM Publish actions are interrupted/incomplete #4343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidgovea opened this issue Oct 1, 2020 · 4 comments
Closed

🔥 [🐛] NPM Publish actions are interrupted/incomplete #4343

davidgovea opened this issue Oct 1, 2020 · 4 comments
Assignees
Labels
help: needs-triage Issue needs additional investigation/triaging. type: bug New bug report Type: Stale Issue has become stale - automatically added by Stale bot

Comments

@davidgovea
Copy link
Contributor

Issue

Re-opening of issue #4283
#4330 attempted to fix, but did not.

Hey @mikehardy -- I discovered while working on #4331 that npm does not have the latest version of each package. It looks like the publish action still has some issues under certain concurrency scenarios.


Interestingly, the app, analytics, and admob are up-to-date on npm. They are alphabetically first, so I'm thinking we have an interrupted-publish issue.

Looking at the Publish actions, here is my understanding of what happened:

  1. Publish was manually triggered: https://github.com/invertase/react-native-firebase/actions/runs/281108519
  2. The new master push triggers another Publish run: https://github.com/invertase/react-native-firebase/runs/1189883874?check_suite_focus=true
  3. The version-bumps are pushed to master, but the action is skipped https://github.com/invertase/react-native-firebase/runs/1189891921?check_suite_focus=true

Project Files

Javascript

N/A

iOS

N/A

Android

N/A


Environment

N/A


@davidgovea davidgovea added help: needs-triage Issue needs additional investigation/triaging. type: bug New bug report labels Oct 1, 2020
@mikehardy
Copy link
Collaborator

Yes - actually I was going to take this up with @Salakar - I'm not sure what's going on here and I don't have the push-to-master authority to conclusively un-fuddle it unfortunately. One hypothesis is the previous push breaks put things in a state the scripts can't self-correct out of. Another hypothesis is that it's something unknown (sounds silly but that hypothesis is always on my list of things to expect, keeps me honest).

It's a bit of a frustration right now for sure but at least current merged functionality is out there I think

@mikehardy
Copy link
Collaborator

I received upgraded permissions just a moment ago and have manually pushed current packages to npmjs.com from the repo so we really should be coherent now for yarn/npm package management. This may keep us straight going forward but @Salakar said he'd take a look tomorrow to verify

@stale
Copy link

stale bot commented Nov 1, 2020

Hello 👋, to help manage issues we automatically close stale issues.
This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require the community's attention?

This issue will be closed in 15 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the Type: Stale Issue has become stale - automatically added by Stale bot label Nov 1, 2020
@stale
Copy link

stale bot commented Nov 26, 2020

Closing this issue after a prolonged period of inactivity. If this is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help: needs-triage Issue needs additional investigation/triaging. type: bug New bug report Type: Stale Issue has become stale - automatically added by Stale bot
Projects
None yet
Development

No branches or pull requests

3 participants