Skip to content

Commit 27298e9

Browse files
committed
fix(exposeAsideWhen): trigger a resize event when the aside is exposed
Closes #3054.
1 parent d8c93b4 commit 27298e9

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

js/angular/directive/collectionRepeat.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -194,14 +194,15 @@ function CollectionRepeatDirective($ionicCollectionManager, $parse, $window, $$r
194194

195195
// Make sure this resize actually changed the size of the screen
196196
function validateResize() {
197-
var h = element[0].offsetHeight, w = element[0].offsetWidth;
197+
var h = scrollView.__clientHeight, w = scrollView.__clientWidth;
198198
if (w && h && (validateResize.height !== h || validateResize.width !== w)) {
199+
validateResize.height = h;
200+
validateResize.width = w;
199201
refreshDimensions();
200202
}
201-
validateResize.height = h;
202-
validateResize.width = w;
203203
}
204204
function refreshDimensions() {
205+
console.log('refreshDimensions', validateResize.height, validateResize.width);
205206
if (heightData.computed || widthData.computed) {
206207
computeStyleDimensions();
207208
}

js/angular/directive/sideMenuContent.js

+1
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,7 @@ function($timeout, $ionicGesture, $window) {
154154
$element[0].style.width = '';
155155
content.offsetX = 0;
156156
}
157+
ionic.trigger('resize', null, window);
157158
}),
158159
setMarginRight: ionic.animationFrameThrottle(function(amount) {
159160
if (amount) {

0 commit comments

Comments
 (0)