Skip to content

Commit 441a21c

Browse files
author
Adam Bradley
committed
fix(popup): Backwards compatible remove popup from DOM, closes #851
1 parent bfcf265 commit 441a21c

File tree

2 files changed

+37
-2
lines changed

2 files changed

+37
-2
lines changed

js/ext/angular/src/service/ionicPopup.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ angular.module('ionic.service.popup', ['ionic.service.templateLoad'])
184184
popup.el.classList.add('popup-hidden');
185185

186186
$timeout(function() {
187-
popup.el.remove();
187+
popup.el.parentNode.removeChild(popup.el);
188188
}, 400);
189189
};
190190

js/ext/angular/test/popup.html

+36-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,42 @@
1717
<button class="button button-balanced" ng-click="showPrompt()">Prompt</button>
1818
<button class="button button-balanced" ng-click="showPasswordPrompt()">Password Prompt</button>
1919
<button class="button button-positive" ng-click="showAlert()">Alert</button>
20-
<div style="height: 3000px; width: 50px; background-color: rgba(0,0,0,0.5);"></div>
20+
<div class="list">
21+
<a class="item" href="#">Item</a>
22+
<a class="item" href="#">Item</a>
23+
<a class="item" href="#">Item</a>
24+
<a class="item" href="#">Item</a>
25+
<a class="item" href="#">Item</a>
26+
<a class="item" href="#">Item</a>
27+
<a class="item" href="#">Item</a>
28+
<a class="item" href="#">Item</a>
29+
<a class="item" href="#">Item</a>
30+
<a class="item" href="#">Item</a>
31+
<a class="item" href="#">Item</a>
32+
<a class="item" href="#">Item</a>
33+
<a class="item" href="#">Item</a>
34+
<a class="item" href="#">Item</a>
35+
<a class="item" href="#">Item</a>
36+
<a class="item" href="#">Item</a>
37+
<a class="item" href="#">Item</a>
38+
<a class="item" href="#">Item</a>
39+
<a class="item" href="#">Item</a>
40+
<a class="item" href="#">Item</a>
41+
<a class="item" href="#">Item</a>
42+
<a class="item" href="#">Item</a>
43+
<a class="item" href="#">Item</a>
44+
<a class="item" href="#">Item</a>
45+
<a class="item" href="#">Item</a>
46+
<a class="item" href="#">Item</a>
47+
<a class="item" href="#">Item</a>
48+
<a class="item" href="#">Item</a>
49+
<a class="item" href="#">Item</a>
50+
<a class="item" href="#">Item</a>
51+
<a class="item" href="#">Item</a>
52+
<a class="item" href="#">Item</a>
53+
<a class="item" href="#">Item</a>
54+
<a class="item" href="#">Item</a>
55+
</div>
2156
</ion-content>
2257

2358
<script id="popup-template.html" type="text/ng-template">

0 commit comments

Comments
 (0)