Skip to content

Commit 491e256

Browse files
Teemuadamdbradley
authored andcommitted
fix(scroll): memory leak on document event listener
resetScrollView event listener is added on document but it is never removed closes #4746
1 parent 5fdb110 commit 491e256

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

js/views/scrollViewNative.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -554,15 +554,14 @@
554554
var self = this;
555555
var container = self.__container;
556556

557-
container.removeEventListener('resetScrollView', self.resetScrollView);
558557
container.removeEventListener('scroll', self.onScroll);
559-
560558
container.removeEventListener('scrollChildIntoView', self.scrollChildIntoView);
561-
container.removeEventListener('resetScrollView', self.resetScrollView);
562559

563560
container.removeEventListener(ionic.EVENTS.touchstart, self.handleTouchMove);
564561
container.removeEventListener(ionic.EVENTS.touchmove, self.handleTouchMove);
565562

563+
document.removeEventListener('resetScrollView', self.resetScrollView);
564+
566565
ionic.tap.removeClonedInputs(container, self);
567566

568567
delete self.__container;

0 commit comments

Comments
 (0)