Skip to content

Commit 67ea34a

Browse files
felquisajoslin
authored andcommitted
docs($ionicModal): clearly note that .modal wrapper is required
Closes #1384. Just to avoid mistakes/questions like this http://forum.ionicframework.com/t/ionic-modal-not-animating/4196
1 parent 30a9da1 commit 67ea34a

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

js/angular/controller/scrollController.js

-2
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,6 @@ function($scope, scrollViewOptions, $timeout, $window, $$scrollValueCache, $loca
165165
}
166166
};
167167

168-
169-
170168
/**
171169
* @private
172170
*/

js/angular/service/modal.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
* @module ionic
55
* @description
66
* The Modal is a content pane that can go over the user's main view
7-
* temporarily. Usually used for making a choice or editing an item.
7+
* temporarily. Usually used for making a choice or editing an item.
8+
* Note that you need to put the content of the modal inside a div with the class `modal`.
89
*
910
* @usage
1011
* ```html

0 commit comments

Comments
 (0)