Skip to content

Commit e10b5d2

Browse files
jskrzypekmhartington
authored andcommitted
fix(util): Fix preventDefault logic in ionic.Gesture.gestures.Drag
Fixes #4008 fix(ionSideMenu): prevent native scrolling when menu is open
1 parent b426556 commit e10b5d2

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

Diff for: js/utils/gestures.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1171,8 +1171,8 @@
11711171

11721172
} else if (!this.preventedFirstMove && ev.srcEvent.type == 'touchmove') {
11731173
// Prevent gestures that are not intended for this event handler from firing subsequent times
1174-
if (inst.options.prevent_default_directions.length === 0
1175-
|| inst.options.prevent_default_directions.indexOf(ev.direction) != -1) {
1174+
if (inst.options.prevent_default_directions.length > 0
1175+
&& inst.options.prevent_default_directions.indexOf(ev.direction) != -1) {
11761176
ev.srcEvent.preventDefault();
11771177
}
11781178
this.preventedFirstMove = true;

Diff for: scss/_menu.scss

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
.menu-open .menu-content .pane,
3636
.menu-open .menu-content .scroll-content {
3737
pointer-events: none;
38+
overflow: hidden;
3839
}
3940

4041
.grade-b .menu-content,

0 commit comments

Comments
 (0)