bug: unreachable code in ionic.activator.start. ion-item's without ng-click cant get activated class

[djett41]

Type: bug

Platform: all

ion-item directives without ng-click, or other HTML elements with an item class that are NOT anchors or buttons will not receive the activated class on mouse/tap down/move events.

In the ionic.activator.start method line 3100 in beta14, if any condition is met that set's the eleToActivate variable, the for loop is broken out of, therefore even if your element or element's parent contains the .item class, the code below will never evaluate to true (eleToActivate will always be undefined)

if (eleToActivate && ele.classList.contains('item')) {
  eleToActivate = ele;
  break;
}

Removing the check for eleToActivate should resolve the issue

[mhartington]

So if they're not elements that you can tap, then why provide any visual feed back?
I don't really see any point to this to be honest. From a usability standpoint, it would create confusion as to whats a button and what not.

[djett41]

@mhartington maybe I was unclear. These are definitely tappable elements

1. Suppose you had a ion-item or a directive with the item class, and you want it to get the activated class, but wanted to implement an touch event handler other than ng-click, or say you just used jquery lite to implement the click handler in the directive..... The element would never get the activated class.
2. The line of code i'm referring actually includes the check (looks for .item class) which would allow Add support for "tap" virtual event #1 to get the activated class. The problem is that the first part of the condition (check is eleToActivate is defined) will NEVER BE TRUE therefore the code for the condition is unreachable. So even if you decided that you don't want to give user's the flexibility and want to restrict them to using ng-click for items... you still have unreachable code in your codebase.

[djett41]

@mhartington the following issue is related to exactly what I am saying. #3050

Removing the check for eleToActivate in line 3100 in beta14 ionic.js, would allow @sgon00 to be able to use ion-item with href and still get the activated class, rather than being forced to use ng-click as he described in his example.

[mhartington]

Will pass this to @adamdbradley

[PerfectionVR]

This is in ionic.bundle.js 1.2.0 at line 3222

      var eleToActivate;
      //Two lines omitted
      if (eleToActivate && ele.classList && ele.classList.contains('item')) {
        eleToActivate = ele;
        break;
      }

If this helps any.

[jgw96]

Hello all! Is this still an issue with the latest version of ionic? Thanks!

[jgw96]

Hello all! As it seems it has been a while since there was any activity on this issue i will be closing it for now. Feel free to comment if you are still running into this issue. Thanks for using Ionic!