feat: Make getPortal accessible via the JS interface. (#32)

Fixes discrepancies between the two platforms with regards to how they are called from JS.

Author: Steven0351

ios/PortalManager.m

@@ -13,7 +13,7 @@ @interface RCT_EXTERN_MODULE(IONPortalsReactNative, NSObject)
 RCT_EXTERN_METHOD(enableSecureLiveUpdates: (NSString *) publicKeyPath resolver: (RCTPromiseResolveBlock) resolver rejector: (RCTPromiseRejectBlock) rejector)
 RCT_EXTERN_METHOD(addPortal: (NSDictionary) portal resolver: (RCTPromiseResolveBlock) resolver rejector: (RCTPromiseRejectBlock) rejector)
 RCT_EXTERN_METHOD(addPortals: (NSArray) portals resolver: (RCTPromiseResolveBlock) resolver rejector: (RCTPromiseRejectBlock) rejector)
-RCT_EXTERN_METHOD(getPortalNamed: (NSString *) name resolver: (RCTPromiseResolveBlock) resolver rejector: (RCTPromiseRejectBlock) rejector)
+RCT_EXTERN_METHOD(getPortal: (NSString *) name resolver: (RCTPromiseResolveBlock) resolver rejector: (RCTPromiseRejectBlock) rejector)
 RCT_EXTERN_METHOD(syncOne: (NSString *) appId resolver: (RCTPromiseResolveBlock) resolver rejector: (RCTPromiseRejectBlock) rejector)
 RCT_EXTERN_METHOD(syncSome: (NSArray) appIds resolver: (RCTPromiseResolveBlock) resolver rejector: (RCTPromiseRejectBlock) rejector)
 RCT_EXTERN_METHOD(syncAll: (RCTPromiseResolveBlock) resolver)

ios/PortalsReactNative.swift

@@ -45,7 +45,7 @@ public class PortalsReactNative: NSObject {
         resolver(())
     }
 
-    @objc func enableSecureLiveUpdates(_ publicKeyPath: String, resolver: RCTPromiseResolveBlock) {
+    @objc func enableSecureLiveUpdates(_ publicKeyPath: String, resolver: RCTPromiseResolveBlock, rejector: RCTPromiseRejectBlock) {
         guard let publicKeyUrl = Bundle.main.url(forResource: publicKeyPath, withExtension: nil) else { fatalError("Public key not found at \(publicKeyPath)") }
         lum = SecureLiveUpdateManager(named: "secure-updates", publicKeyUrl: publicKeyUrl)
         resolver(())
@@ -69,7 +69,7 @@ public class PortalsReactNative: NSObject {
 
     static func getPortal(named name: String) -> Portal? { portals[name] }
 
-    @objc func getPortalNamed(name: String, resolver: RCTPromiseResolveBlock, rejector: RCTPromiseRejectBlock) {
+    @objc func getPortal(_ name: String, resolver: RCTPromiseResolveBlock, rejector: RCTPromiseRejectBlock) {
         guard let portal = Self.getPortal(named: name) else { return rejector(nil, "Portal named \(name) not registered", nil) }
         resolver(portal.dict)
     }

src/index.ts

@@ -81,6 +81,7 @@ export const publish = (topic: string, data: any) => {
 /**
  * Validates that a valid registration key has been procured from http://ionic.io/register-portals
  * @param key The registration key
+ * @returns Promise<void>
  */
 export const register = async (key: string): Promise<void> => {
   return IONPortalsReactNative.register(key);
@@ -125,15 +126,32 @@ export type PortalProps = PortalProp & ViewProps;
  * Adds a Portal to an internal registry. Must be called before attempting to render a {@link PortalView}.
  *
  * @param portal The portal to add to the internal registry.
+ * @returns Promise containing the Portal that was added to the registry.
  */
 export const addPortal = async (portal: Portal): Promise<Portal> => {
   return IONPortalsReactNative.addPortal(portal);
 };
 
+/**
+ * Adds all portals to an internal registry. This or {@link addPortal} must be called before attempting to render a {@link PortalView}
+ *
+ * @param portals The portals to add to the internal registry.
+ * @returns Promise containing the Portals that were added to the registry.
+ */
 export const addPortals = async (portals: Portal[]): Promise<Portal[]> => {
   return IONPortalsReactNative.addPortals(portals);
 };
 
+/**
+ * Gets a {@link Portal} previously registered via {@link addPortal} or {@link addPortals}.
+ *
+ * @param name The portal name to retrieve from the internal registry.
+ * @returns Promise containing the registered {@link Portal}. If the {@link Portal} was not registered, the Promise will fail.
+ */
+export const getPortal = async (name: string): Promise<Portal> => {
+  return IONPortalsReactNative.getPortal(name);
+};
+
 export interface LiveUpdate {
   /** The AppFlow application ID */
   appId: string;
@@ -165,6 +183,7 @@ export interface SyncResults {
  *
  * @param pathToKey The *relative* path to the public key for verification.
  * This path should be the same relatibe to the main application bundle on iOS and the assets directory on Android.
+ * @returns Promise<void>
  */
 export const enableSecureLiveUpdates = async (
   pathToKey: string