Skip to content

Commit 11a4338

Browse files
author
Adam Bradley
committed
fix(item): Fix item-icon-left / right animating Ionicon not centered, closes #670
1 parent a6c47cd commit 11a4338

File tree

2 files changed

+35
-35
lines changed

2 files changed

+35
-35
lines changed

Diff for: scss/_items.scss

+34-34
Original file line numberDiff line numberDiff line change
@@ -58,31 +58,31 @@
5858
}
5959

6060
// Different themes for items
61-
&.item-light {
61+
&.item-light {
6262
@include item-style($item-light-bg, $item-light-border, $item-light-text);
6363
}
64-
&.item-stable {
64+
&.item-stable {
6565
@include item-style($item-stable-bg, $item-stable-border, $item-stable-text);
6666
}
67-
&.item-positive {
67+
&.item-positive {
6868
@include item-style($item-positive-bg, $item-positive-border, $item-positive-text);
6969
}
70-
&.item-calm {
70+
&.item-calm {
7171
@include item-style($item-calm-bg, $item-calm-border, $item-calm-text);
7272
}
73-
&.item-assertive {
73+
&.item-assertive {
7474
@include item-style($item-assertive-bg, $item-assertive-border, $item-assertive-text);
7575
}
76-
&.item-balanced {
76+
&.item-balanced {
7777
@include item-style($item-balanced-bg, $item-balanced-border, $item-balanced-text);
7878
}
79-
&.item-energized {
79+
&.item-energized {
8080
@include item-style($item-energized-bg, $item-energized-border, $item-energized-text);
8181
}
82-
&.item-royal {
82+
&.item-royal {
8383
@include item-style($item-royal-bg, $item-royal-border, $item-royal-text);
8484
}
85-
&.item-dark {
85+
&.item-dark {
8686
@include item-style($item-dark-bg, $item-dark-border, $item-dark-text);
8787
}
8888

@@ -95,51 +95,51 @@
9595
@include item-active-style($item-default-active-bg, $item-default-active-border);
9696

9797
// Different active themes for <a> and <button> items
98-
&.item-light {
98+
&.item-light {
9999
@include item-active-style($item-light-active-bg, $item-light-active-border);
100100
}
101-
&.item-stable {
101+
&.item-stable {
102102
@include item-active-style($item-stable-active-bg, $item-stable-active-border);
103103
}
104-
&.item-positive {
104+
&.item-positive {
105105
@include item-active-style($item-positive-active-bg, $item-positive-active-border);
106106
}
107-
&.item-calm {
107+
&.item-calm {
108108
@include item-active-style($item-calm-active-bg, $item-calm-active-border);
109109
}
110-
&.item-assertive {
110+
&.item-assertive {
111111
@include item-active-style($item-assertive-active-bg, $item-assertive-active-border);
112112
}
113-
&.item-balanced {
113+
&.item-balanced {
114114
@include item-active-style($item-balanced-active-bg, $item-balanced-active-border);
115115
}
116-
&.item-energized {
116+
&.item-energized {
117117
@include item-active-style($item-energized-active-bg, $item-energized-active-border);
118118
}
119-
&.item-royal {
119+
&.item-royal {
120120
@include item-active-style($item-royal-active-bg, $item-royal-active-border);
121121
}
122-
&.item-dark {
122+
&.item-dark {
123123
@include item-active-style($item-dark-active-bg, $item-dark-active-border);
124124
}
125125
}
126126

127127
// Handle text overflow
128128
.item,
129-
.item h1,
130-
.item h2,
131-
.item h3,
132-
.item h4,
133-
.item h5,
134-
.item h6,
129+
.item h1,
130+
.item h2,
131+
.item h3,
132+
.item h4,
133+
.item h5,
134+
.item h6,
135135
.item p,
136136
.item-content,
137-
.item-content h1,
138-
.item-content h2,
139-
.item-content h3,
140-
.item-content h4,
141-
.item-content h5,
142-
.item-content h6,
137+
.item-content h1,
138+
.item-content h2,
139+
.item-content h3,
140+
.item-content h4,
141+
.item-content h5,
142+
.item-content h6,
143143
.item-content p {
144144
overflow: hidden;
145145
text-overflow: ellipsis;
@@ -245,7 +245,7 @@ a.item-content {
245245

246246
&:before {
247247
display: block;
248-
width: $item-icon-font-size - 4;
248+
width: $item-icon-font-size;
249249
text-align: center;
250250
}
251251
}
@@ -375,7 +375,7 @@ button.item.item-button-right {
375375
* then a arrow will be added to the right side of the item.
376376
*/
377377

378-
a.item,
378+
a.item,
379379
button.item,
380380
.item a[href].item-content,
381381
.item[ng-click] a.item-content {
@@ -494,7 +494,7 @@ button.item-button-right:after,
494494
.item-image {
495495
padding: 0;
496496
text-align: center;
497-
497+
498498
img:first-child, .list-img {
499499
width: 100%;
500500
vertical-align: middle;
@@ -510,7 +510,7 @@ button.item-button-right:after,
510510
padding: $item-padding;
511511
text-overflow: inherit;
512512
white-space: normal;
513-
513+
514514
h1, h2, h3, h4, h5, h6, p {
515515
margin-top: $item-padding;
516516
margin-bottom: $item-padding;

Diff for: test/html/lists.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ <h1 class="title">Lists</h1>
132132
</div>
133133

134134
<a href="#" class="item item-icon-left">
135-
<i class="icon ion-mic-a positive"></i>
135+
<i class="icon ion-loading-d positive"></i>
136136
Record album
137137
<span class="item-note">
138138
Grammy

0 commit comments

Comments
 (0)