Skip to content

Commit 16ac2ff

Browse files
author
Adam Bradley
committed
fix(sidemenu): Side menu always needs to have translate3d applied, closes #710
1 parent ed1dbb7 commit 16ac2ff

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

Diff for: js/ext/angular/src/directive/ionicSideMenu.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -113,11 +113,7 @@ angular.module('ionic.ui.sideMenu', ['ionic.service.gesture', 'ionic.service.vie
113113
return $scope.sideMenuContentTranslateX || 0;
114114
},
115115
setTranslateX: ionic.animationFrameThrottle(function(amount) {
116-
if(amount === 0) {
117-
$element[0].style[ionic.CSS.TRANSFORM] = 'none';
118-
} else {
119-
$element[0].style[ionic.CSS.TRANSFORM] = 'translate3d(' + amount + 'px, 0, 0)';
120-
}
116+
$element[0].style[ionic.CSS.TRANSFORM] = 'translate3d(' + amount + 'px, 0, 0)';
121117
$timeout(function() {
122118
$scope.sideMenuContentTranslateX = amount;
123119
});

Diff for: scss/_menu.scss

+5-5
Original file line numberDiff line numberDiff line change
@@ -26,20 +26,20 @@
2626

2727
.grade-b .menu-content,
2828
.grade-c .menu-content {
29+
@include box-sizing(content-box);
2930
right: -1px;
3031
left: -1px;
31-
@include box-sizing(content-box);
3232
border-right: 1px solid #ccc;
3333
border-left: 1px solid #ccc;
3434
box-shadow: none;
3535
}
3636

37-
.menu-left {
38-
left: 0;
37+
.menu-left {
38+
left: 0;
3939
}
4040

41-
.menu-right {
42-
right: 0;
41+
.menu-right {
42+
right: 0;
4343
}
4444

4545
.menu-animated {

0 commit comments

Comments
 (0)