Skip to content

Commit 2ec0173

Browse files
committed
fix(refresher): make arrow spin correctly
Closes #1319
1 parent 5be42bc commit 2ec0173

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

Diff for: js/angular/directive/refresher.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,9 @@ IonicModule
6767
'<div class="scroll-refresher">' +
6868
'<div class="ionic-refresher-content" ' +
6969
'ng-class="{\'ionic-refresher-with-text\': pullingText || refreshingText}">' +
70-
'<i class="icon {{pullingIcon}} icon-pulling"></i>' +
70+
'<div class="icon-pulling">' +
71+
'<i class="icon {{pullingIcon}}"></i>' +
72+
'</div>' +
7173
'<div class="text-pulling" ng-bind-html="pullingText"></div>' +
7274
'<i class="icon {{refreshingIcon}} icon-refreshing"></i>' +
7375
'<div class="text-refreshing" ng-bind-html="refreshingText"></div>' +

Diff for: test/unit/angular/directive/refresher.unit.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,12 @@ describe('ionRefresher directive', function() {
6868

6969
it('should have default pullingIcon', function() {
7070
var el = setup();
71-
expect(el[0].querySelector('.icon.icon-pulling.ion-arrow-down-c')).toBeTruthy();
71+
expect(el[0].querySelector('.icon-pulling .ion-arrow-down-c')).toBeTruthy();
7272
});
7373
it('should allow custom pullingIcon', function() {
7474
var el = setup('pulling-icon="super-icon"');
75-
expect(el[0].querySelector('.icon.icon-pulling.ion-arrow-down-c')).toBeFalsy();
76-
expect(el[0].querySelector('.icon.icon-pulling.super-icon')).toBeTruthy();
75+
expect(el[0].querySelector('.icon-pulling .ion-arrow-down-c')).toBeFalsy();
76+
expect(el[0].querySelector('.icon-pulling .super-icon')).toBeTruthy();
7777
});
7878

7979
it('should have default refreshingIcon', function() {

0 commit comments

Comments
 (0)