Skip to content

Commit 31de853

Browse files
committed
fix(popup): make sure backdrop is always released
Closes #3524.
1 parent 4a65807 commit 31de853

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

Diff for: js/angular/service/popup.js

+2-3
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,7 @@ function($ionicTemplateLoader, $ionicBackdrop, $q, $timeout, $rootScope, $ionicB
376376
} else {
377377
//Add popup-open & backdrop if this is first popup
378378
$ionicBody.addClass('popup-open');
379+
console.log("RETAIN");
379380
$ionicBackdrop.retain();
380381
//only show the backdrop on the first popup
381382
$ionicPopup._backButtonActionDone = $ionicPlatform.registerBackButtonAction(
@@ -409,6 +410,7 @@ function($ionicTemplateLoader, $ionicBackdrop, $q, $timeout, $rootScope, $ionicB
409410
popupStack.splice(index, 1);
410411
}
411412
popup.remove();
413+
$ionicBackdrop.release();
412414

413415
if (popupStack.length > 0) {
414416
popupStack[popupStack.length - 1].show();
@@ -421,9 +423,6 @@ function($ionicTemplateLoader, $ionicBackdrop, $q, $timeout, $rootScope, $ionicB
421423
$ionicBody.removeClass('popup-open');
422424
}
423425
}, 400, false);
424-
$timeout(function() {
425-
if (!popupStack.length) $ionicBackdrop.release();
426-
}, config.stackPushDelay || 0, false);
427426

428427
($ionicPopup._backButtonActionDone || noop)();
429428
}

0 commit comments

Comments
 (0)