Skip to content

Commit 518e54e

Browse files
rvanbaalenajoslin
authored andcommitted
feat($ionicSideMenuDelegate): add isOpen() method
Closes #1074. Closes #1075.
1 parent dfbb376 commit 518e54e

File tree

3 files changed

+26
-1
lines changed

3 files changed

+26
-1
lines changed

Diff for: js/controllers/sideMenuController.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@
117117
},
118118

119119
isOpen: function() {
120-
return this.getOpenRatio() == 1;
120+
return this.getOpenAmount() !== 0;
121121
},
122122

123123
/**

Diff for: js/ext/angular/src/directive/ionicSideMenu.js

+6
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,12 @@ angular.module('ionic.ui.sideMenu', ['ionic.service.gesture', 'ionic.service.vie
8585
* opened/opening, and between 0 and -1 if right menu is opened/opening.
8686
*/
8787
'getOpenRatio',
88+
/**
89+
* @ngdoc method
90+
* @name $ionicSideMenuDelegate#isOpen
91+
* @returns {boolean} Whether either the left or right menu is currently opened.
92+
*/
93+
'isOpen',
8894
/**
8995
* @ngdoc method
9096
* @name $ionicSideMenuDelegate#isOpenLeft

Diff for: test/unit/controllers/sideMenuController.unit.js

+19
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,25 @@ describe('SideMenuController', function() {
104104
expect(ctrl.getOpenPercentage()).toEqual(0);
105105
});
106106

107+
it('should isOpen', function() {
108+
expect(ctrl.isOpen()).toEqual(false);
109+
ctrl.toggleLeft();
110+
expect(ctrl.isOpen()).toEqual(true);
111+
ctrl.toggleLeft();
112+
expect(ctrl.isOpen()).toEqual(false);
113+
ctrl.toggleLeft();
114+
expect(ctrl.isOpen()).toEqual(true);
115+
ctrl.toggleLeft();
116+
117+
expect(ctrl.isOpen()).toEqual(false);
118+
ctrl.toggleRight();
119+
expect(ctrl.isOpen()).toEqual(true);
120+
ctrl.toggleRight();
121+
expect(ctrl.isOpen()).toEqual(false);
122+
ctrl.toggleRight();
123+
expect(ctrl.isOpen()).toEqual(true);
124+
});
125+
107126
it('should isOpenLeft', function() {
108127
expect(ctrl.isOpenLeft()).toEqual(false);
109128
ctrl.toggleLeft();

0 commit comments

Comments
 (0)