Skip to content

Commit 58de267

Browse files
committed
fix(ionNavButtons): multiple ionNavButtons elements align correctly
Fixes #930 Uses a `<span>` now for each set buttons in the navbar, instead of a `<div>`. This means that the buttons will align correctly instead of creating new lines for each set of buttons.
1 parent f039fc2 commit 58de267

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Diff for: js/ext/angular/src/directive/ionicNavBar.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -450,11 +450,11 @@ function($ionicViewService, $rootScope, $animate, $compile) {
450450
navBarCtrl.rightButtonsElement :
451451
navBarCtrl.leftButtonsElement;
452452

453-
//Put all of our inside buttons into their own div,
453+
//Put all of our inside buttons into their own span,
454454
//so we can remove them all when this element dies -
455455
//even if the buttons have changed through an ng-repeat or the like,
456456
//we just remove their div parent and they are gone.
457-
var buttons = angular.element('<div>').append(content);
457+
var buttons = angular.element('<span>').append(content);
458458

459459
//Compile buttons inside content so they have access to everything
460460
//something inside content does (eg parent ionicScroll)

0 commit comments

Comments
 (0)