Skip to content

Commit bfd01a7

Browse files
committed
Prevent click events from firing twice on Windows Phone (tested on 8.1 and 10).
1 parent d2a83ea commit bfd01a7

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

Diff for: js/utils/tap.js

+3
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,9 @@ ionic.tap = {
236236
},
237237

238238
requiresNativeClick: function(ele) {
239+
if (ionic.Platform.isWindowsPhone && (ele.tagName == 'A' || ele.tagName == 'BUTTON' || ele.hasAttribute('ng-click') || (ele.tagName == 'INPUT' && (ele.type == 'button' || ele.type == 'submit')))) {
240+
return true; //Windows Phone edge case, prevent ng-click (and similar) events from firing twice on this platform
241+
}
239242
if (!ele || ele.disabled || (/^(file|range)$/i).test(ele.type) || (/^(object|video)$/i).test(ele.tagName) || ionic.tap.isLabelContainingFileInput(ele)) {
240243
return true;
241244
}

0 commit comments

Comments
 (0)