Skip to content

Commit 6001e9e

Browse files
lindlofjorgemmsilva
authored andcommitted
internal/ethapi, signer/core: fix documentation-links (ethereum#28979)
fix: management api links
1 parent c4a8b4c commit 6001e9e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

internal/ethapi/api.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -530,7 +530,7 @@ func (s *PersonalAccountAPI) SignTransaction(ctx context.Context, args Transacti
530530
//
531531
// The key used to calculate the signature is decrypted with the given password.
532532
//
533-
// https://github.com/ethereum/go-ethereum/wiki/Management-APIs#personal_sign
533+
// https://geth.ethereum.org/docs/interacting-with-geth/rpc/ns-personal#personal-sign
534534
func (s *PersonalAccountAPI) Sign(ctx context.Context, data hexutil.Bytes, addr common.Address, passwd string) (hexutil.Bytes, error) {
535535
// Look up the wallet containing the requested signer
536536
account := accounts.Account{Address: addr}
@@ -558,7 +558,7 @@ func (s *PersonalAccountAPI) Sign(ctx context.Context, data hexutil.Bytes, addr
558558
// Note, the signature must conform to the secp256k1 curve R, S and V values, where
559559
// the V value must be 27 or 28 for legacy reasons.
560560
//
561-
// https://github.com/ethereum/go-ethereum/wiki/Management-APIs#personal_ecRecover
561+
// https://geth.ethereum.org/docs/interacting-with-geth/rpc/ns-personal#personal-ecrecover
562562
func (s *PersonalAccountAPI) EcRecover(ctx context.Context, data, sig hexutil.Bytes) (common.Address, error) {
563563
if len(sig) != crypto.SignatureLength {
564564
return common.Address{}, fmt.Errorf("signature must be %d bytes long", crypto.SignatureLength)

signer/core/signed_data.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ func (api *SignerAPI) EcRecover(ctx context.Context, data hexutil.Bytes, sig hex
302302
// Note, the signature must conform to the secp256k1 curve R, S and V values, where
303303
// the V value must be 27 or 28 for legacy reasons.
304304
//
305-
// https://github.com/ethereum/go-ethereum/wiki/Management-APIs#personal_ecRecover
305+
// https://geth.ethereum.org/docs/tools/clef/apis#account-ecrecover
306306
if len(sig) != 65 {
307307
return common.Address{}, errors.New("signature must be 65 bytes long")
308308
}

0 commit comments

Comments
 (0)