This repository was archived by the owner on Jan 13, 2023. It is now read-only.
fix: traverse_bundle checks for zero trytes #292
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: #291
Description
get_bundles
callstraverseBundleCommand
internally, which in turn callsgetTrytesCommand
to fetch the trytes for transactions in the bundle.Therefore,
getTrytesCommand
doesn't return an empty list, rather a list with an empty transaction in it, meaning that all trytes of the transaction are '9's.Detecting such cases when trying to fetch a bundle from the Tangle and throwing an exception.