Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Commit a5a4c37

Browse files
dryajovdaviddias
authored andcommitted
fix: make tests consistent across js-ipfs/go-ipfs (#158)
* feat: add progress bar tests * feat: fixing progress bar tests * fix: consistent tests across js-ipfs and go-ipfs progress * fix: rename progress acumulators for clarity
1 parent 5954440 commit a5a4c37

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

src/files.js

+8-8
Original file line numberDiff line numberDiff line change
@@ -127,20 +127,20 @@ module.exports = (common) => {
127127
const expectedMultihash = 'Qme79tX2bViL26vNjPsF3DP1R9rMKMvnPYJiKTTKPrXJjq'
128128

129129
let progCount = 0
130-
let progress = 0
130+
let accumProgress = 0
131131
const handler = (p) => {
132132
progCount += 1
133-
progress += p
133+
accumProgress = p
134134
}
135135

136-
ipfs.files.add(bigFile, {progress: handler}, (err, res) => {
136+
ipfs.files.add(bigFile, { progress: handler }, (err, res) => {
137137
expect(err).to.not.exist()
138138
expect(res).to.have.length(1)
139139
const file = res[0]
140140
expect(file.hash).to.equal(expectedMultihash)
141141
expect(file.path).to.equal(file.hash)
142142
expect(progCount).to.equal(58)
143-
expect(progress).to.equal(bigFile.byteLength)
143+
expect(accumProgress).to.equal(bigFile.byteLength)
144144
done()
145145
})
146146
})
@@ -214,20 +214,20 @@ module.exports = (common) => {
214214
}, 0)
215215

216216
let progCount = 0
217-
let progress = 0
217+
let accumProgress = 0
218218
const handler = (p) => {
219219
progCount += 1
220-
progress += p
220+
accumProgress += p
221221
}
222222

223-
ipfs.files.add(dirs, {progress: handler}, (err, res) => {
223+
ipfs.files.add(dirs, { progress: handler }, (err, res) => {
224224
expect(err).to.not.exist()
225225
const root = res[res.length - 1]
226226

227227
expect(root.path).to.equal('test-folder')
228228
expect(root.hash).to.equal(expectedRootMultihash)
229229
expect(progCount).to.equal(8)
230-
expect(progress).to.equal(total)
230+
expect(accumProgress).to.be.at.least(total)
231231
done()
232232
})
233233
})

0 commit comments

Comments
 (0)