This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Interface for files.add #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also replaces the old javascript test data with Project Gutenberg prose. Also returns object wrapping path+node on ipfs.files.add.
| @@ -2,8 +2,8 @@ | |||
| "name": "interface-ipfs-core", | |||
| "version": "0.1.5", | |||
| "description": "A test suite and interface you can use to implement a IPFS core interface.", | |||
| "main": "test/index.js", | |||
| "jsnext:main": "test/index.js", | |||
| "main": "lib/index.js", | |||
There was a problem hiding this comment.
Get's build on publish, check
|
Thanks for taking this the last mile, @diasdavid. 🐴 LGTM, other than my one comment. |
…or fs, stop requiring fs inside functions (breaks webpack)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #20
Adds