Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

Commit bd5f0ae

Browse files
author
Alan Shaw
committed
fix: test skips and fix disconnect arg toString
1 parent 0ac9c19 commit bd5f0ae

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

Diff for: src/swarm/disconnect.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ module.exports = configure(({ ky }) => {
88
options = options || {}
99

1010
const searchParams = new URLSearchParams(options.searchParams)
11-
addrs.forEach(addr => searchParams.append('arg', addr))
11+
addrs.forEach(addr => searchParams.append('arg', `${addr}`))
1212

1313
const res = await ky.post('swarm/disconnect', {
1414
timeout: options.timeout,

Diff for: test/interface.spec.js

+16-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,18 @@ describe('interface-ipfs-core tests', () => {
7070
}]
7171
})
7272

73-
tests.bootstrap(commonFactory)
73+
tests.bootstrap(commonFactory, {
74+
skip: [{
75+
name: 'should return a list containing the bootstrap peer when called with a valid arg (ip4)',
76+
reason: 'TODO unskip when go-ipfs switches to p2p for libp2p keys'
77+
}, {
78+
name: 'should prevent duplicate inserts of bootstrap peers',
79+
reason: 'TODO unskip when go-ipfs switches to p2p for libp2p keys'
80+
}, {
81+
name: 'should return a list containing the peer removed when called with a valid arg (ip4)',
82+
reason: 'TODO unskip when go-ipfs switches to p2p for libp2p keys'
83+
}]
84+
})
7485

7586
tests.config(commonFactory, {
7687
skip: [
@@ -125,6 +136,10 @@ describe('interface-ipfs-core tests', () => {
125136
name: 'should ls directory',
126137
reason: 'TODO unskip when go-ipfs supports --long https://github.com/ipfs/go-ipfs/pull/6528'
127138
},
139+
{
140+
name: 'should list a file directly',
141+
reason: 'TODO unskip when go-ipfs supports --long https://github.com/ipfs/go-ipfs/pull/6528'
142+
},
128143
{
129144
name: 'should ls directory and include metadata',
130145
reason: 'TODO not implemented in go-ipfs yet'

0 commit comments

Comments
 (0)