fix: default cid version to 0 temporarily

Currently we cannot default CID version to 1 in MFS write as read will hang. ipfs-inactive/js-ipfs-mfs#12

License: MIT
Signed-off-by: Alan Shaw <[email protected]>

Author: Alan Shaw

API.md

@@ -438,7 +438,7 @@ Write data to an MFS (Mutable File System) file.
 | options.parents | `Boolean` | Create parent directories if not exists, default: `false` |
 | options.truncate | `Boolean` | Truncate the file after writing, default: `false` |
 | options.rawLeaves | `Boolean` | Do not wrap leaf nodes in a protobuf, default: `false` |
-| options.cidVersion | `Number` | CID version to use when creating the node(s), default: 1 |
+| options.cidVersion | `Number` | CID version to use when creating the node(s), default: ~~1~~ FIXME: currently 0 due to https://github.com/ipfs/js-ipfs-mfs/issues/12 |
 
 #### Returns
 

src/write.js

@@ -6,7 +6,8 @@ module.exports = backend => {
     input = toIterable(input)
     options = options || {}
     options.create = options.create == null ? true : options.create
-    options.cidVersion = options.cidVersion == null ? 1 : options.cidVersion
+    // FIXME: https://github.com/ipfs/js-ipfs-mfs/issues/12
+    options.cidVersion = options.cidVersion == null ? 0 : options.cidVersion
 
     const inputGenerator = async function * () {
       for await (const chunk of input) {

test/helpers/port-service/server.js

@@ -7,16 +7,14 @@ const PortManager = require('port-manager')
 const shortid = require('shortid')
 const { DEFAULT_PORT_SERVICE_ADDR } = require('./')
 
-const AutoReleaseHeartbeat = 5000
-
 module.exports = async addr => {
   addr = Multiaddr(addr || process.env.PORT_SERVICE_ADDR || DEFAULT_PORT_SERVICE_ADDR)
 
   if (!addr.protoNames().includes('http')) {
     throw new Error('invalid protocol')
   }
 
-  const portManager = new PortManager(AutoReleaseHeartbeat).include(3000, 9999)
+  const portManager = new PortManager().include(3000, 9999)
 
   const claim = name => new Promise((resolve, reject) => {
     portManager.claim(name, (err, service) => {
@@ -34,6 +32,7 @@ module.exports = async addr => {
 
   const queue = new Queue(1)
 
+  // TODO: implement release endpoint so we don't run out of ports!
   const handler = req => {
     const queryParams = QueryString.parse(req.url.split('?')[1] || '')
     const numPorts = getNumPorts(queryParams)

test/write.test.js

@@ -42,7 +42,7 @@ test('should write from iterator of buffer', async t => {
 
 test('should write from async iterator of buffer', async t => {
   const { node } = t.context
-  const path = `/test-write-iterator-${Date.now()}.txt`
+  const path = `/test-write-async-iterator-${Date.now()}.txt`
   const data = randomArray(1, 100, () => randomBytes(randomInteger(1, 64)))
   const iterator = async function * () {
     for (let i = 0; i < data.length; i++) {