fix!: use arrays for collections instead of sets

Because we have `uniqueItems: true` in our service definition yaml, fields with `type: array` are generated as `Set`s by the typescript generator.

Serialization/deserialization of these types is [broken](OpenAPITools/openapi-generator#11746) so where we use these APIs [we pass arrays with `@ts-expect-error` anyway](https://github.com/ipfs/helia-remote-pinning/blob/main/src/heliaRemotePinner.ts#L155).

It doesn't look possible to override the use of Set by the generator in a way that works (`type-mappings=set=array` produces uncompilable code) so manually change the generated code.

Also adds a note to the readme reminding people to do it.

BREAKING CHANGE: fields that were Sets such as `PinResults.results` and `PinsGetRequest.cid` are now Arrays

Author: achingbrain

README.md

@@ -29,7 +29,7 @@ const client = new RemotePinningServiceClient(config)
   // Get 10 failed Pins
   const pinsGetOptions: PinsGetRequest = {
     limit: 10,
-    status: new Set([Status.Failed]) // requires a set, and not an array
+    status: [Status.Failed]
   }
   const {count, results}: PinResults = await client.pinsGet(pinsGetOptions)
 
@@ -53,6 +53,8 @@ npm run build
 
 To update the client, you need to `npm run gen` npm script. This will fetch the latest version of the OpenAPI spec and generate the client. However, openapi-generator-cli does not currently generate the client code with proper import syntax. So you must modify the imports in `generated/fetch/**` directly, or just `git checkout -p` to remove the invalid import path changes.
 
+It also uses `Set`s for all collection types though it cannot serialize or deserialize these types to/from JSON. They must be manually changed to be `Array`s.
+
 If you need to modify the generated code's import paths, you will have to run `npm run postgen` manually.
 
 ### Contributing

generated/fetch/src/apis/PinsApi.ts

@@ -38,8 +38,8 @@ describe('Client', () => {
 
     it('GET: Can get failed Pins', async () => {
       const Client = new RemotePinningServiceClient(Config)
-      const response = await Client.pinsGet({ limit: 1, status: new Set([Status.Failed]) })
-      expect(response).to.deep.eq({ count: 0, results: new Set() })
+      const response = await Client.pinsGet({ limit: 1, status: [Status.Failed] })
+      expect(response).to.deep.eq({ count: 0, results: [] })
     })
 
     it('GET: Can add a Pin successfully', async () => {