linting

Author: willscott

fuzz/cmd/compare/main.go

@@ -101,6 +101,4 @@ func main() {
 	}
 
 	fmt.Printf("Done\n")
-
-	return
 }

fuzz/cmd/generate/main.go

@@ -1,4 +1,4 @@
-// This file is invoked at the fuzzer level by `go generate`
+// This file is invoked by `go generate`
 package main
 
 import (
@@ -36,17 +36,21 @@ func main() {
 		name := nameComponents[len(nameComponents)-1]
 		f, err := os.Create(fmt.Sprintf("provider_%s.go", name))
 		if err != nil {
-			fmt.Fprintf(os.Stderr, "failed to create provider file: %v", err)
+			fmt.Fprintf(os.Stderr, "failed to create provider file: %v\n", err)
 			os.Exit(1)
 		}
 		defer f.Close()
-		provideTemplate.Execute(f, struct {
+		err = provideTemplate.Execute(f, struct {
 			Package     string
 			PackageName string
 		}{
 			Package:     provider,
 			PackageName: name,
 		})
+		if err != nil {
+			fmt.Fprintf(os.Stderr, "failed to write provider: %v\n", err)
+			os.Exit(1)
+		}
 	}
 }
 

fuzz/fuzzer.go

@@ -46,7 +46,7 @@ type RunState struct {
 
 	keyCache   [128]ds.Key
 	cachedKeys int32
-	ctr        int32
+	ctr        int32 //nolint:unused
 }
 
 // DB returns the datastore being driven by this instance
@@ -192,7 +192,7 @@ const (
 	opMax
 )
 
-func threadDriver(ctx context.Context, runState *RunState, cmnds chan byte) error {
+func threadDriver(ctx context.Context, runState *RunState, cmnds chan byte) {
 	defer runState.wg.Done()
 	s := threadState{}
 	s.RunState = runState
@@ -203,11 +203,11 @@ func threadDriver(ctx context.Context, runState *RunState, cmnds chan byte) erro
 		select {
 		case c, ok := <-cmnds:
 			if !ok {
-				return nil
+				return
 			}
 			_ = nextState(&s, c)
 		case <-ctx.Done():
-			return nil
+			return
 		}
 	}
 }
@@ -220,21 +220,21 @@ func nextState(s *threadState, c byte) error {
 		if !s.keyReady {
 			return makeKey(s, c)
 		}
-		s.reader.Get(s.key)
+		_, _ = s.reader.Get(s.key)
 		reset(s)
 		return nil
 	} else if s.op == opHas {
 		if !s.keyReady {
 			return makeKey(s, c)
 		}
-		s.reader.Has(s.key)
+		_, _ = s.reader.Has(s.key)
 		reset(s)
 		return nil
 	} else if s.op == opGetSize {
 		if !s.keyReady {
 			return makeKey(s, c)
 		}
-		s.reader.GetSize(s.key)
+		_, _ = s.reader.GetSize(s.key)
 		reset(s)
 		return nil
 	} else if s.op == opQuery {
@@ -255,14 +255,14 @@ func nextState(s *threadState, c byte) error {
 		if !s.valReady {
 			return makeValue(s, c)
 		}
-		s.writer.Put(s.key, s.val)
+		_ = s.writer.Put(s.key, s.val)
 		reset(s)
 		return nil
 	} else if s.op == opDelete {
 		if !s.keyReady {
 			return makeKey(s, c)
 		}
-		s.writer.Delete(s.key)
+		_ = s.writer.Delete(s.key)
 		reset(s)
 		return nil
 	} else if s.op == opNewTX {
@@ -297,7 +297,7 @@ func nextState(s *threadState, c byte) error {
 		if !s.keyReady {
 			return makeKey(s, c)
 		}
-		s.RunState.inst.Sync(s.key)
+		_ = s.RunState.inst.Sync(s.key)
 		reset(s)
 		return nil
 	}