Skip to content

Commit 5272e6b

Browse files
committed
style(asyncloader): cleanup code to check error
1 parent 38c82d3 commit 5272e6b

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

requestmanager/asyncloader/asyncloader.go

+7-5
Original file line numberDiff line numberDiff line change
@@ -164,15 +164,17 @@ func (al *AsyncLoader) CompleteResponsesFor(requestID graphsync.RequestID) {
164164
func (al *AsyncLoader) CleanupRequest(p peer.ID, requestID graphsync.RequestID) {
165165
al.stateLk.Lock()
166166
defer al.stateLk.Unlock()
167+
responseCache := al.responseCache
167168
aq, ok := al.requestQueues[requestID]
168169
if ok {
169-
toFree := al.alternateQueues[aq].responseCache.FinishRequest(requestID)
170-
al.allocator.ReleaseBlockMemory(p, toFree)
170+
responseCache = al.alternateQueues[aq].responseCache
171171
delete(al.requestQueues, requestID)
172-
return
173172
}
174-
toFree := al.responseCache.FinishRequest(requestID)
175-
al.allocator.ReleaseBlockMemory(p, toFree)
173+
toFree := responseCache.FinishRequest(requestID)
174+
err := al.allocator.ReleaseBlockMemory(p, toFree)
175+
if err != nil {
176+
log.Infow("Error deallocating requestor memory", "p", p, "toFree", toFree, "err", err)
177+
}
176178
}
177179

178180
func (al *AsyncLoader) getLoadAttemptQueue(queue string) *loadattemptqueue.LoadAttemptQueue {

0 commit comments

Comments
 (0)