Merge pull request #95 from ipfs/release/v0.1.2

Release/v0.1.2

Author: hannahhoward

CHANGELOG.md

@@ -147,6 +147,22 @@ Minor fix for alternate persistence stores and deduplication
 |-------------|---------|---------|---------------|
 | Hannah Howard | 1 | +316/-7 | 10 |
 
+# go-graphsync 0.1.2
+
+Minor release with initial benchmarks
+
+### Changelog
+
+- github.com/ipfs/go-graphsync:
+  - Benchmark framework + First memory fixes (#89) ([ipfs/go-graphsync#89](https://github.com/ipfs/go-graphsync/pull/89))
+  - docs(CHANGELOG): update for v0.1.1 ([ipfs/go-graphsync#85](https://github.com/ipfs/go-graphsync/pull/85))
+
+### Contributors
+
+| Contributor | Commits | Lines ± | Files Changed |
+|-------------|---------|---------|---------------|
+| Hannah Howard | 1 | +1055/-39 | 17 |
+
 ### 🙌🏽 Want to contribute?
 
 Would you like to contribute to this repo and don’t know how? Here are a few places you can get started:

benchmarks/benchmark_test.go

@@ -16,8 +16,6 @@ import (
 
 	"github.com/ipfs/go-blockservice"
 	"github.com/ipfs/go-cid"
-	"github.com/ipfs/go-graphsync/benchmarks/testinstance"
-	tn "github.com/ipfs/go-graphsync/benchmarks/testnet"
 	blockstore "github.com/ipfs/go-ipfs-blockstore"
 	chunker "github.com/ipfs/go-ipfs-chunker"
 	delay "github.com/ipfs/go-ipfs-delay"
@@ -33,6 +31,9 @@ import (
 	"github.com/ipld/go-ipld-prime/traversal/selector/builder"
 	mocknet "github.com/libp2p/go-libp2p/p2p/net/mock"
 	"github.com/stretchr/testify/require"
+
+	"github.com/ipfs/go-graphsync/benchmarks/testinstance"
+	tn "github.com/ipfs/go-graphsync/benchmarks/testnet"
 )
 
 const stdBlockSize = 8000

benchmarks/testinstance/testinstance.go

@@ -8,17 +8,18 @@ import (
 	ds "github.com/ipfs/go-datastore"
 	"github.com/ipfs/go-datastore/delayed"
 	ds_sync "github.com/ipfs/go-datastore/sync"
-	graphsync "github.com/ipfs/go-graphsync"
-	tn "github.com/ipfs/go-graphsync/benchmarks/testnet"
-	gsimpl "github.com/ipfs/go-graphsync/impl"
-	gsnet "github.com/ipfs/go-graphsync/network"
-	"github.com/ipfs/go-graphsync/storeutil"
 	blockstore "github.com/ipfs/go-ipfs-blockstore"
 	delay "github.com/ipfs/go-ipfs-delay"
 	"github.com/ipld/go-ipld-prime"
 	peer "github.com/libp2p/go-libp2p-core/peer"
 	p2ptestutil "github.com/libp2p/go-libp2p-netutil"
 	tnet "github.com/libp2p/go-libp2p-testing/net"
+
+	graphsync "github.com/ipfs/go-graphsync"
+	tn "github.com/ipfs/go-graphsync/benchmarks/testnet"
+	gsimpl "github.com/ipfs/go-graphsync/impl"
+	gsnet "github.com/ipfs/go-graphsync/network"
+	"github.com/ipfs/go-graphsync/storeutil"
 )
 
 // TempDirGenerator is any interface that can generate temporary directories

benchmarks/testnet/interface.go

@@ -1,10 +1,10 @@
 package testnet
 
 import (
-	gsnet "github.com/ipfs/go-graphsync/network"
-
 	"github.com/libp2p/go-libp2p-core/peer"
 	tnet "github.com/libp2p/go-libp2p-testing/net"
+
+	gsnet "github.com/ipfs/go-graphsync/network"
 )
 
 // Network is an interface for generating graphsync network interfaces
@@ -13,4 +13,3 @@ type Network interface {
 	Adapter(tnet.Identity) gsnet.GraphSyncNetwork
 	HasPeer(peer.ID) bool
 }
-

benchmarks/testnet/internet_latency_delay_generator_test.go

@@ -6,8 +6,9 @@ import (
 	"testing"
 	"time"
 
-	"github.com/ipfs/go-graphsync/benchmarks/testnet"
 	"github.com/stretchr/testify/require"
+
+	"github.com/ipfs/go-graphsync/benchmarks/testnet"
 )
 
 const testSeed = 99

benchmarks/testnet/network_test.go

@@ -6,13 +6,13 @@ import (
 	"testing"
 
 	blocks "github.com/ipfs/go-block-format"
-	"github.com/ipfs/go-graphsync/benchmarks/testnet"
-	gsmsg "github.com/ipfs/go-graphsync/message"
-	gsnet "github.com/ipfs/go-graphsync/network"
 	delay "github.com/ipfs/go-ipfs-delay"
-
 	"github.com/libp2p/go-libp2p-core/peer"
 	tnet "github.com/libp2p/go-libp2p-testing/net"
+
+	"github.com/ipfs/go-graphsync/benchmarks/testnet"
+	gsmsg "github.com/ipfs/go-graphsync/message"
+	gsnet "github.com/ipfs/go-graphsync/network"
 )
 
 func TestSendMessageAsyncButWaitForResponse(t *testing.T) {

benchmarks/testnet/virtual.go

@@ -7,15 +7,14 @@ import (
 	"sync"
 	"time"
 
-	gsmsg "github.com/ipfs/go-graphsync/message"
-	gsnet "github.com/ipfs/go-graphsync/network"
-
 	delay "github.com/ipfs/go-ipfs-delay"
 	mockrouting "github.com/ipfs/go-ipfs-routing/mock"
-
 	"github.com/libp2p/go-libp2p-core/peer"
 	tnet "github.com/libp2p/go-libp2p-testing/net"
 	mocknet "github.com/libp2p/go-libp2p/p2p/net/mock"
+
+	gsmsg "github.com/ipfs/go-graphsync/message"
+	gsnet "github.com/ipfs/go-graphsync/network"
 )
 
 // VirtualNetwork generates a new testnet instance - a fake network that

requestmanager/asyncloader/asyncloader.go

@@ -117,11 +117,7 @@ func (al *AsyncLoader) AsyncLoad(requestID graphsync.RequestID, link ipld.Link)
 	resultChan := make(chan types.AsyncLoadResult, 1)
 	response := make(chan error, 1)
 	lr := loadattemptqueue.NewLoadRequest(requestID, link, resultChan)
-	err := al.sendSyncMessage(&loadRequestMessage{response, requestID, lr}, response)
-	if err != nil {
-		resultChan <- types.AsyncLoadResult{Data: nil, Err: err}
-		close(resultChan)
-	}
+	_ = al.sendSyncMessage(&loadRequestMessage{response, requestID, lr}, response)
 	return resultChan
 }