better url generation

whyrusleeping · whyrusleeping · commit 90d33def085a · 2016-03-16T21:27:06.000-07:00
diff --git a/request.go b/request.go
@@ -133,13 +133,14 @@ func (r *Request) Send(c *http.Client) (*Response, error) {
 }
 
 func (r *Request) getURL() string {
-	argstring := ""
+
+	values := make(url.Values)
 	for _, arg := range r.Args {
-		argstring += fmt.Sprintf("arg=%s&", url.QueryEscape(arg))
+		values.Add("arg", arg)
 	}
 	for k, v := range r.Opts {
-		argstring += fmt.Sprintf("%s=%s&", url.QueryEscape(k), url.QueryEscape(v))
+		values.Add(k, v)
 	}
 
-	return fmt.Sprintf("%s/%s?%s", r.ApiBase, r.Command, argstring)
+	return fmt.Sprintf("%s/%s?%s", r.ApiBase, r.Command, values.Encode())
 }

Original file line number	Diff line number	Diff line change
`@@ -133,13 +133,14 @@ func (r Request) Send(c http.Client) (*Response, error) {`
`133`	`133`	`}`
`134`	`134`
`135`	`135`	`func (r *Request) getURL() string {`
`136`		`- argstring := ""`
	`136`	`+`
	`137`	`+ values := make(url.Values)`
`137`	`138`	`for _, arg := range r.Args {`
`138`		`- argstring += fmt.Sprintf("arg=%s&", url.QueryEscape(arg))`
	`139`	`+ values.Add("arg", arg)`
`139`	`140`	`}`
`140`	`141`	`for k, v := range r.Opts {`
`141`		`- argstring += fmt.Sprintf("%s=%s&", url.QueryEscape(k), url.QueryEscape(v))`
	`142`	`+ values.Add(k, v)`
`142`	`143`	`}`
`143`	`144`
`144`		`- return fmt.Sprintf("%s/%s?%s", r.ApiBase, r.Command, argstring)`
	`145`	`+ return fmt.Sprintf("%s/%s?%s", r.ApiBase, r.Command, values.Encode())`
`145`	`146`	`}`