fix: OptionalString String() default

lidel · lidel · commit 58610896c840 · 2021-10-29T17:08:15.000+02:00
#153 (review)
diff --git a/types.go b/types.go
@@ -358,7 +358,7 @@ func (p *OptionalString) UnmarshalJSON(input []byte) error {
 
 func (p OptionalString) String() string {
 	if p.value == nil {
-		return ""
+		return "default"
 	}
 	return *p.value
 }
diff --git a/types_test.go b/types_test.go
@@ -409,8 +409,8 @@ func TestOptionalString(t *testing.T) {
 	if val := defaultOptionalString.WithDefault(""); val != "" {
 		t.Errorf("optional string should have been empty, got %s", val)
 	}
-	if val := defaultOptionalString.String(); val != "" {
-		t.Fatalf("default optional string should be an empty string, got %s", val)
+	if val := defaultOptionalString.String(); val != "default" {
+		t.Fatalf("default optional string should be the 'default' string, got %s", val)
 	}
 	if val := defaultOptionalString.WithDefault("foo"); val != "foo" {
 		t.Errorf("optional string should have been foo, got %s", val)

Original file line number	Diff line number	Diff line change
`@@ -358,7 +358,7 @@ func (p *OptionalString) UnmarshalJSON(input []byte) error {`
`358`	`358`
`359`	`359`	`func (p OptionalString) String() string {`
`360`	`360`	`if p.value == nil {`
`361`		`- return ""`
	`361`	`+ return "default"`
`362`	`362`	`}`
`363`	`363`	`return *p.value`
`364`	`364`	`}`
Original file line number	Diff line number	Diff line change
`@@ -409,8 +409,8 @@ func TestOptionalString(t *testing.T) {`
`409`	`409`	`if val := defaultOptionalString.WithDefault(""); val != "" {`
`410`	`410`	`t.Errorf("optional string should have been empty, got %s", val)`
`411`	`411`	`}`
`412`		`- if val := defaultOptionalString.String(); val != "" {`
`413`		`- t.Fatalf("default optional string should be an empty string, got %s", val)`
	`412`	`+ if val := defaultOptionalString.String(); val != "default" {`
	`413`	`+ t.Fatalf("default optional string should be the 'default' string, got %s", val)`
`414`	`414`	`}`
`415`	`415`	`if val := defaultOptionalString.WithDefault("foo"); val != "foo" {`
`416`	`416`	`t.Errorf("optional string should have been foo, got %s", val)`