Fix go test on Windows #4632
Merged
Fix go test on Windows #4632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Closed
|
libp2p/go-libp2p-peer#28 has been merged and this seems to be ready to be merged. |
|
It has been merged, though it needs to be propagated. #4637 updates go-libp2p-peer, though one version before thin fix |
|
@magik6k this will need a rebase. Let me know when its good to go |
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
magik6k
force-pushed
the
fix/windows-tests
branch
from
e8b0ba6 to
dcfcfc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes windows issues @victorbjelkholm had in #4430 (comment).
There is still one test failing:
This will need a fix in https://github.com/libp2p/go-libp2p-peer/blob/master/test/utils.go#L23. The problem here is that
time.Now().UnixNano()resolution on windows is really poor (multiple ms)