-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Cleanup instances of manual resolver construction #5492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c1e5412
to
094dc98
Compare
Could you provide me some pointers about this PR that would help me review it? |
The idea (mentioned in #5491) is that we want to start using the coreapi resolver basically everywhere. The resolver was discussed in #4666 / #4672, the TL;DR is that it decides which resolver to use based on the prefix, so that |
} | ||
|
||
// A ReadSeekCloser implements interfaces to read, copy, seek and close. | ||
type ReadSeekCloser interface { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code seems to be repeating the interfaces already defined in go-unixfs
:
https://github.com/ipfs/go-unixfs/blob/master/io/dagreader.go#L22-L37
(Or maybe it's the other way around and UnixFS is duplicating these ones, either way, is it possible for one to reference the other?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will be doable once the coreapi interface is extracted, which I hope will happen fairly soon - for progress see #4498 (I want to have pubsub/swarm/unixfs done before extracting the interface)
License: MIT Signed-off-by: Łukasz Magiera <[email protected]>
094dc98
to
1ed555b
Compare
Part of #5491
Given how messy and all-over-the-place this PR is, I'd rather keep it small. This only cleans up places which constructed their own resolver. I'll take care of the other parts, which use
node.Resolver
in next PR