CounterVec: even more ergonomic

hsanjuan · hsanjuan · commit 1534fc53828b · 2025-02-19T16:41:30.000+01:00
diff --git a/interface.go b/interface.go
@@ -12,11 +12,9 @@ type Counter interface {
 	Add(float64) // Only positive
 }
 
-type Labels map[string]string
-
 // CounterVec is a counter with tags.
 type CounterVec interface {
-	With(Labels) Counter
+	WithLabelValues(lvs ...string) Counter
 }
 
 // Gauge is a metric that can be increased and decreased.
@@ -48,7 +46,7 @@ type SummaryOpts struct {
 // Creator can be used to create different types of metrics.
 type Creator interface {
 	Counter() Counter
-	CounterVec() CounterVec
+	CounterVec(labelNames []string) CounterVec
 	Gauge() Gauge
 	Histogram(buckets []float64) Histogram
 
diff --git a/noop.go b/noop.go
@@ -27,7 +27,7 @@ func (g *noop) Observe(v float64) {
 	// Noop
 }
 
-func (g *noop) With(labels Labels) Counter {
+func (g *noop) WithLabelValues(lvs ...string) Counter {
 	return g
 }
 
@@ -37,7 +37,7 @@ func (g *noop) Counter() Counter {
 	return g
 }
 
-func (g *noop) CounterVec() CounterVec {
+func (g *noop) CounterVec(lvs []string) CounterVec {
 	return g
 }
 
diff --git a/version.json b/version.json
@@ -1,3 +1,3 @@
 {
-  "version": "v0.2.0"
+  "version": "v0.3.0"
 }

Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ func (g *noop) Observe(v float64) {`
`27`	`27`	`// Noop`
`28`	`28`	`}`
`29`	`29`
`30`		`-func (g *noop) With(labels Labels) Counter {`
	`30`	`+func (g *noop) WithLabelValues(lvs ...string) Counter {`
`31`	`31`	`return g`
`32`	`32`	`}`
`33`	`33`
`@@ -37,7 +37,7 @@ func (g *noop) Counter() Counter {`
`37`	`37`	`return g`
`38`	`38`	`}`
`39`	`39`
`40`		`-func (g *noop) CounterVec() CounterVec {`
	`40`	`+func (g *noop) CounterVec(lvs []string) CounterVec {`
`41`	`41`	`return g`
`42`	`42`	`}`
`43`	`43`