Skip to content

Commit 0cd87ab

Browse files
lidelSgtPooki
andauthored
feat: kubo 0.29 and native apple silicon (#1856)
* refactor: macos universal build * refactor: switch to macos-latest (arm) * feat(macos): build universal kubo binary * fix(ci): switch back to lts node This also tests ipfs/npm-kubo#74 removing the need for hack from #2662 * chore: remove coactions/setup-xvfb modern linux image at github includes it out of the box and we use xvfb-maybe internally to use it when appropriate * chore: update .github/CODEOWNERS * chore: kubo v0.29.0 * chore: electron-updater bumping to include: windows fix: https://github.com/electron-userland/electron-builder/releases/tag/electron-updater%406.1.9 macos fix: https://github.com/electron-userland/electron-builder/releases/tag/electron-updater%406.2.1 * chore: ensure release as 0.36.0 Release-As: 0.36.0 Co-authored-by: Russell Dempsey <[email protected]>
1 parent 6580094 commit 0cd87ab

File tree

6 files changed

+1541
-438
lines changed

6 files changed

+1541
-438
lines changed

.github/CODEOWNERS

+9-1
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,12 @@
55
# these owners will be requested for review when someone
66
# opens a pull request.
77
# All GUI Teams: @ipfs-shipyard/ipfs-gui @ipfs-shipyard/gui @ipfs/gui-dev @ipfs/wg-gui-ux
8-
* @ipfs/gui-dev @sgtpooki @whizzzkid
8+
* @ipfs/gui-dev @sgtpooki
9+
10+
# Explicit ping when changes impact build and release pipeline
11+
electron-builder.yml @lidel
12+
release-please-config.json @lidel
13+
pkgs/ @lidel
14+
.github/workflows/ci.yml @lidel
15+
src/auto-updater/ @lidel
16+

.github/workflows/ci.yml

+6-9
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
- name: Install Node.js
2525
uses: actions/setup-node@v4
2626
with:
27-
node-version: '18.17.1'
27+
node-version: 'lts/*'
2828

2929
- name: Read ipfs-webui CID from package.json
3030
id: read-webui-version
@@ -78,7 +78,7 @@ jobs:
7878
strategy:
7979
fail-fast: false
8080
matrix:
81-
os: [macos-13, ubuntu-latest, windows-latest]
81+
os: [macos-latest, ubuntu-latest, windows-latest]
8282

8383
steps:
8484
- name: Check out Git repository
@@ -87,7 +87,7 @@ jobs:
8787
- name: Install Node.js
8888
uses: actions/setup-node@v4
8989
with:
90-
node-version: '18.17.1'
90+
node-version: 'lts/*'
9191

9292
- name: Read ipfs-webui CID from package.json
9393
id: read-webui-version
@@ -131,10 +131,7 @@ jobs:
131131
run: npm run test
132132

133133
- name: Test end-to-end
134-
uses: coactions/setup-xvfb@b6b4fcfb9f5a895edadc3bc76318fae0ac17c8b3 # v1.0.1
135-
with:
136-
working-directory: ${{ github.workspace }}
137-
run: npm run test:e2e
134+
run: npm run test:e2e
138135

139136
- name: Lint
140137
run: npm run lint
@@ -145,7 +142,7 @@ jobs:
145142
strategy:
146143
fail-fast: false
147144
matrix:
148-
os: [macos-13, ubuntu-latest, windows-latest]
145+
os: [macos-latest, ubuntu-latest, windows-latest]
149146

150147
steps:
151148
- name: Check out Git repository
@@ -154,7 +151,7 @@ jobs:
154151
- name: Install Node.js
155152
uses: actions/setup-node@v4
156153
with:
157-
node-version: '18.17.1'
154+
node-version: 'lts/*'
158155

159156
- name: Read ipfs-webui CID from package.json
160157
id: read-webui-version

electron-builder.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ mac:
2424
entitlements: './pkgs/macos/entitlements.mac.plist'
2525
entitlementsInherit: './pkgs/macos/entitlements.mac.plist'
2626
target:
27-
- zip
28-
- dmg
27+
- target: default
28+
arch: ['universal']
2929

3030
dmg:
3131
artifactName: ${name}-${version}-mac.${ext}

0 commit comments

Comments
 (0)