Skip to content

Commit 7b3c49b

Browse files
authoredMar 10, 2020
fix: startup on Debian 10 (#1370)
This disables sandboxing in ipfs-desktop.desktop manifest which is used by Desktop Environments for generating menus and icons used for starting apps. Rationale for this decision can be found at: #1362 (comment) License: MIT Signed-off-by: Marcin Rataj <[email protected]>
1 parent b04f9dd commit 7b3c49b

File tree

4 files changed

+223
-256
lines changed

4 files changed

+223
-256
lines changed
 

‎README.md

+28
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ IPFS Desktop allows you to run your IPFS Node on your machine without having to
3030
- [Contribute](#contribute)
3131
- [Translations](#translations)
3232
- [FAQ](#faq)
33+
- [Troubleshooting](#troubleshooting)
3334

3435
## Features
3536

@@ -164,6 +165,33 @@ Since we're using [ipfsd-ctl](https://github.com/ipfs/js-ipfsd-ctl), we have our
164165

165166
By default we use the flags `--migrate=true --routing=dhtclient ----enable-gc=true` when running the IPFS daemon. They can be changed via the configuration file, which can be easily accessed as mentioned above.
166167

168+
## Troubleshooting
169+
170+
### Does not start on Linux (Debian 10)
171+
172+
Some Linux users may see an error like this:
173+
174+
> The SUID sandbox helper binary was found, but is not configured correctly.
175+
Rather than run without sandboxing I'm aborting now. You need to make sure that
176+
chrome-sandbox is owned by root and has mode 4755.
177+
178+
or a very short one, when starting in a terminal:
179+
180+
```console
181+
$ ipfs-desktop
182+
$Trace/breakpoint trap
183+
```
184+
185+
This is a known issue with Electron/Chrome and some hardened kernels.
186+
If you are interested in details, read [this](https://github.com/ipfs-shipyard/ipfs-desktop/issues/1362#issuecomment-596857282).
187+
188+
The only reliable way to fix this at the moment is to start the app with additional parameter:
189+
190+
```console
191+
$ ipfs-desktop --no-sandbox
192+
```
193+
194+
167195
## License
168196

169197
[MIT Protocol Labs, Inc.](./LICENSE)

‎electron-builder.yml

+2
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ nsis:
3535
linux:
3636
artifactName: ${name}-${version}-${os}-${arch}.${ext}
3737
executableName: ipfs-desktop
38+
executableArgs:
39+
- --no-sandbox
3840
icon: ipfs-desktop
3941
category: Network;FileTransfer;P2P
4042
synopsis: A desktop client for IPFS

‎package-lock.json

+190-253
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@
5858
"cross-env": "^6.0.3",
5959
"delay": "^4.3.0",
6060
"dirty-chai": "^2.0.1",
61-
"electron": "^7.1.11",
62-
"electron-builder": "^22.3.2",
61+
"electron": "^7.1.14",
62+
"electron-builder": "^22.3.6",
6363
"mocha": "^6.2.2",
6464
"npm-run-all": "^4.1.5",
6565
"pre-commit": "^1.2.2",
@@ -80,7 +80,7 @@
8080
"countly-sdk-nodejs": "^19.8.0",
8181
"electron-serve": "^0.4.1",
8282
"electron-store": "^5.1.0",
83-
"electron-updater": "^4.2.0",
83+
"electron-updater": "^4.2.4",
8484
"fix-path": "^2.1.0",
8585
"fs-extra": "^8.1.0",
8686
"get-port": "^5.1.1",

0 commit comments

Comments
 (0)
Please sign in to comment.