feat: kubo 0.34 + electron 35 + windows signing (#2936)

* feat: kubo 0.34+ electron 35

* test: proper test of post-init state

this ensures we have a test that confirms AutoTLS.Enabled=true
being explicitly set in config of new IPFS Desktop repo
(to skip AutoTLS.RegistrationDelay introduced in Kubo 0.34)

* feat(win): trusted signing with azure

this may require profile name, azure permissions and secrets to be adjusted
before it actually works

* chore: electron-builder v26.0.11

trying latest code to solve azure signing issues

* chore: kubo v0.34.1

Author: lidel

.github/workflows/ci.yml

@@ -230,9 +230,6 @@ jobs:
           max_attempts: 2
           # GH token for attaching atrifacts to release draft on tag build
           github_token: ${{ secrets.github_token }}
-          # Windows signing
-          windows_certs: ${{ secrets.windows_certs }}
-          windows_certs_password: ${{ secrets.windows_certs_password }}
           # Apple signing
           mac_certs: ${{ secrets.mac_certs }}
           mac_certs_password: ${{ secrets.mac_certs_password }}
@@ -244,6 +241,10 @@ jobs:
           # Apple notarization
           APPLEID: ${{ secrets.apple_id }}
           APPLEIDPASS: ${{ secrets.apple_id_pass }}
+          # Windows Azure Trusted Signing
+          AZURE_TENANT_ID: ${{secrets.AZURE_TENANT_ID}}
+          AZURE_CLIENT_ID: ${{secrets.AZURE_CLIENT_ID}}
+          AZURE_CLIENT_SECRET: ${{secrets.AZURE_CLIENT_SECRET}}
 
       - name: Show dist/
         run: du -sh dist/ && ls -l dist/

electron-builder.yml

@@ -43,14 +43,28 @@ dmg:
       type: link
       path: /Applications
 
+win:
+  target:
+    - nsis
+    # TODO - portable
+  azureSignOptions:
+    publisherName: 'IPFS Project'
+    endpoint: 'https://eus.codesigning.azure.net'
+    certificateProfileName: 'ipfs-desktop'
+    codeSigningAccountName: 'pl-code-signing'
+
 nsis:
+  artifactName: ${name}-setup-${version}-${os}-${arch}.${ext}
   include: assets/build/nsis.nsh
   oneClick: false
   warningsAsErrors: false
   perMachine: false
   allowElevation: true
   allowToChangeInstallationDirectory: true
 
+portable:
+  artifactName: ${name}-portable-${version}-${os}-${arch}.${ext}
+
 linux:
   artifactName: ${name}-${version}-${os}-${arch}.${ext}
   executableName: ipfs-desktop