Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS-native integrations (Windows/macOS) fail with Error: Pattern must be a string #1973

Closed
lidel opened this issue Feb 8, 2022 · 1 comment · Fixed by #1976
Closed

OS-native integrations (Windows/macOS) fail with Error: Pattern must be a string #1973

lidel opened this issue Feb 8, 2022 · 1 comment · Fixed by #1976
Assignees
@hacdias
Labels
area/macos MacOS area/windows Windows exp/intermediate Prior experience is likely helpful need/triage Needs initial labeling and prioritization P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented Feb 8, 2022 •
edited
Loading

Found a bug during manual QA from https://github.com/ipfs/ipfs-desktop/blob/main/DEVELOPER-NOTES.md#manual-testing
This is blocking 0.19 release.

Bug

Build 3bc3a8a fail to import a single file via context menu in Windows' File Explorer with error Error: Pattern must be a string in error.log

Error comes from add-to-ipfs.js (probably similar problem as one fixed in 13de174)

Notes

  • fix is most likely fixing type somewhere – needs analysis
  • we need unit tests for add-to-ipfs.js, it breaks too often, every time there are changes in JS API interfaces
@lidel lidel added area/windows Windows need/triage Needs initial labeling and prioritization labels Feb 8, 2022
@lidel lidel self-assigned this Feb 8, 2022
@lidel lidel changed the title MS Windows: Error: Pattern must be a string OS-native integrations (Windows/macOS) fail with Error: Pattern must be a string Feb 8, 2022
@lidel lidel added area/macos MacOS exp/intermediate Prior experience is likely helpful P0 Critical: Tackled by core team ASAP P1 High: Likely tackled by core team if no one steps up and removed P0 Critical: Tackled by core team ASAP labels Feb 8, 2022
@lidel lidel removed their assignment Feb 8, 2022
@lidel
Copy link
Member Author

lidel commented Feb 8, 2022 •
edited
Loading

@hacdias would you have time for this (Friday)?

@hacdias hacdias mentioned this issue Feb 9, 2022
Merged
@TinyTb TinyTb moved this to Done in IP JS (PL EngRes) v2 Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacdias hacdias

Labels
area/macos MacOS area/windows Windows exp/intermediate Prior experience is likely helpful need/triage Needs initial labeling and prioritization P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
IP JS (PL EngRes) v2
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use new glob source API ipfs/ipfs-desktop
2 participants
@lidel @hacdias