Skip to content

Commit 4a87fea

Browse files
authored
Merge pull request #6601 from ipfs/fix/6595
cmds/refs: fix ipfs refs for sharded directories
2 parents d61269f + 4f6069f commit 4a87fea

File tree

2 files changed

+7
-14
lines changed

2 files changed

+7
-14
lines changed

core/commands/refs.go

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,14 @@ import (
77
"io"
88
"strings"
99

10-
core "github.com/ipfs/go-ipfs/core"
1110
cmdenv "github.com/ipfs/go-ipfs/core/commands/cmdenv"
12-
"github.com/ipfs/go-ipfs/namesys/resolve"
1311

1412
cid "github.com/ipfs/go-cid"
1513
cidenc "github.com/ipfs/go-cidutil/cidenc"
1614
cmds "github.com/ipfs/go-ipfs-cmds"
1715
ipld "github.com/ipfs/go-ipld-format"
18-
path "github.com/ipfs/go-path"
16+
iface "github.com/ipfs/interface-go-ipfs-core"
17+
path "github.com/ipfs/interface-go-ipfs-core/path"
1918
)
2019

2120
var refsEncoderMap = cmds.EncoderMap{
@@ -75,7 +74,7 @@ NOTE: List all references recursively by using the flag '-r'.
7574
}
7675

7776
ctx := req.Context
78-
n, err := cmdenv.GetNode(env)
77+
api, err := cmdenv.GetApi(env, req)
7978
if err != nil {
8079
return err
8180
}
@@ -103,14 +102,14 @@ NOTE: List all references recursively by using the flag '-r'.
103102
format = "<src> -> <dst>"
104103
}
105104

106-
objs, err := objectsForPaths(ctx, n, req.Arguments)
105+
objs, err := objectsForPaths(ctx, api, req.Arguments)
107106
if err != nil {
108107
return err
109108
}
110109

111110
rw := RefWriter{
112111
res: res,
113-
DAG: n.DAG,
112+
DAG: api.Dag(),
114113
Ctx: ctx,
115114
Unique: unique,
116115
PrintFmt: format,
@@ -165,15 +164,10 @@ Displays the hashes of all local objects.
165164
Type: RefWrapper{},
166165
}
167166

168-
func objectsForPaths(ctx context.Context, n *core.IpfsNode, paths []string) ([]ipld.Node, error) {
167+
func objectsForPaths(ctx context.Context, n iface.CoreAPI, paths []string) ([]ipld.Node, error) {
169168
objects := make([]ipld.Node, len(paths))
170169
for i, sp := range paths {
171-
p, err := path.ParsePath(sp)
172-
if err != nil {
173-
return nil, err
174-
}
175-
176-
o, err := resolve.Resolve(ctx, n.Namesys, n.Resolver, p)
170+
o, err := n.ResolveNode(ctx, path.New(sp))
177171
if err != nil {
178172
return nil, err
179173
}

go.mod

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ require (
110110
go.uber.org/multierr v1.1.0 // indirect
111111
go4.org v0.0.0-20190313082347-94abd6928b1d // indirect
112112
golang.org/x/sys v0.0.0-20190626221950-04f50cda93cb
113-
google.golang.org/appengine v1.4.0 // indirect
114113
gopkg.in/cheggaaa/pb.v1 v1.0.28
115114
gotest.tools/gotestsum v0.3.4
116115
)

0 commit comments

Comments
 (0)