fix concurrent SetError in pin command

(segfault)

Also, buffer the response channel. I believe we had a go routine leak here
before.

License: MIT
Signed-off-by: Steven Allen <[email protected]>

Author: Stebalien

core/commands/pin.go

@@ -90,32 +90,31 @@ var addPinCmd = &cmds.Command{
 		v := new(dag.ProgressTracker)
 		ctx := v.DeriveContext(req.Context())
 
-		ch := make(chan []*cid.Cid)
+		type pinResult struct {
+			pins []*cid.Cid
+			err  error
+		}
+		ch := make(chan pinResult, 1)
 		go func() {
-			defer close(ch)
 			added, err := corerepo.Pin(n, ctx, req.Arguments(), recursive)
-			if err != nil {
-				res.SetError(err, cmdkit.ErrNormal)
-				return
-			}
-			ch <- added
+			ch <- pinResult{pins: added, err: err}
 		}()
 
 		ticker := time.NewTicker(500 * time.Millisecond)
 		defer ticker.Stop()
 		defer close(out)
 		for {
 			select {
-			case val, ok := <-ch:
-				if !ok {
-					// error already set just return
+			case val := <-ch:
+				if val.err != nil {
+					res.SetError(err, cmdkit.ErrNormal)
 					return
 				}
 
 				if pv := v.Value(); pv != 0 {
 					out <- &AddPinOutput{Progress: v.Value()}
 				}
-				out <- &AddPinOutput{Pins: cidsToStrings(val)}
+				out <- &AddPinOutput{Pins: cidsToStrings(val.pins)}
 				return
 			case <-ticker.C:
 				out <- &AddPinOutput{Progress: v.Value()}