Skip to content

Commit 7d7d693

Browse files
committed
namesys/pubsub_test: smaller test
make it work with seemingly low fdlimits in travis/macosx. also, more informative test failures. License: MIT Signed-off-by: vyzo <[email protected]>
1 parent 6cd7c2c commit 7d7d693

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

namesys/pubsub_test.go

+13-10
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ func TestPubsubPublishResolve(t *testing.T) {
104104

105105
name := "/ipns/" + pubhost.ID().Pretty()
106106

107-
reshosts := newNetHosts(ctx, t, 20)
107+
reshosts := newNetHosts(ctx, t, 5)
108108
resmrs := newMockRoutingForHosts(ms, ks, reshosts)
109109
res := make([]Resolver, len(reshosts))
110110
for i := 0; i < len(res); i++ {
@@ -113,22 +113,24 @@ func TestPubsubPublishResolve(t *testing.T) {
113113

114114
time.Sleep(time.Millisecond * 100)
115115
for i := 0; i < len(res); i++ {
116-
checkResolveNotFound(ctx, t, res[i], name)
116+
checkResolveNotFound(ctx, t, i, res[i], name)
117+
// delay to avoid connection storms
117118
time.Sleep(time.Millisecond * 100)
118119
}
119120

120121
// let the bootstrap finish
121-
time.Sleep(time.Second * 3)
122+
time.Sleep(time.Second * 1)
122123

123124
val := path.Path("/ipfs/QmP1DfoUjiWH2ZBo1PBH6FupdBucbDepx3HpWmEY6JMUpY")
124125
err := pub.Publish(ctx, privk, val)
125126
if err != nil {
126127
t.Fatal(err)
127128
}
128129

130+
// let the flood propagate
129131
time.Sleep(time.Second * 3)
130132
for i := 0; i < len(res); i++ {
131-
checkResolve(ctx, t, res[i], name, val)
133+
checkResolve(ctx, t, i, res[i], name, val)
132134
}
133135

134136
val = path.Path("/ipfs/QmP1wMAqk6aZYRZirbaAwmrNeqFRgQrwBt3orUtvSa1UYD")
@@ -137,25 +139,26 @@ func TestPubsubPublishResolve(t *testing.T) {
137139
t.Fatal(err)
138140
}
139141

142+
// let the flood propagate
140143
time.Sleep(time.Second * 3)
141144
for i := 0; i < len(res); i++ {
142-
checkResolve(ctx, t, res[i], name, val)
145+
checkResolve(ctx, t, i, res[i], name, val)
143146
}
144147
}
145148

146-
func checkResolveNotFound(ctx context.Context, t *testing.T, resolver Resolver, name string) {
149+
func checkResolveNotFound(ctx context.Context, t *testing.T, i int, resolver Resolver, name string) {
147150
_, err := resolver.Resolve(ctx, name)
148151
if err != ds.ErrNotFound {
149-
t.Fatalf("unexpected value: %#v", err)
152+
t.Fatalf("[resolver %d] unexpected error: %s", i, err.Error())
150153
}
151154
}
152155

153-
func checkResolve(ctx context.Context, t *testing.T, resolver Resolver, name string, val path.Path) {
156+
func checkResolve(ctx context.Context, t *testing.T, i int, resolver Resolver, name string, val path.Path) {
154157
xval, err := resolver.Resolve(ctx, name)
155158
if err != nil {
156-
t.Fatal(err)
159+
t.Fatalf("[resolver %d] resolve failed: %s", i, err.Error())
157160
}
158161
if xval != val {
159-
t.Fatalf("resolver resolves to unexpected value %s %s", val, xval)
162+
t.Fatalf("[resolver %d] unexpected value: %s %s", i, val, xval)
160163
}
161164
}

0 commit comments

Comments
 (0)