Skip to content

Commit f3bb620

Browse files
committed
feat(systemd): extract socket activation logic
1 parent a49710d commit f3bb620

File tree

5 files changed

+12
-74
lines changed

5 files changed

+12
-74
lines changed

cmd/ipfs/daemon.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import (
1515
version "github.com/ipfs/go-ipfs"
1616
config "github.com/ipfs/go-ipfs-config"
1717
cserial "github.com/ipfs/go-ipfs-config/serialize"
18-
sockets "github.com/ipfs/go-ipfs/cmd/ipfs/sockets"
1918
utilmain "github.com/ipfs/go-ipfs/cmd/ipfs/util"
2019
oldcmds "github.com/ipfs/go-ipfs/commands"
2120
"github.com/ipfs/go-ipfs/core"
@@ -27,6 +26,7 @@ import (
2726
nodeMount "github.com/ipfs/go-ipfs/fuse/node"
2827
fsrepo "github.com/ipfs/go-ipfs/repo/fsrepo"
2928
migrate "github.com/ipfs/go-ipfs/repo/fsrepo/migrations"
29+
sockets "github.com/libp2p/go-socket-activation"
3030

3131
"github.com/hashicorp/go-multierror"
3232
cmds "github.com/ipfs/go-ipfs-cmds"
@@ -440,7 +440,7 @@ func serveHTTPApi(req *cmds.Request, cctx *oldcmds.Context) (<-chan error, error
440440
return nil, fmt.Errorf("serveHTTPApi: GetConfig() failed: %s", err)
441441
}
442442

443-
listeners, err := sockets.TakeSockets("io.ipfs.api")
443+
listeners, err := sockets.TakeListeners("io.ipfs.api")
444444
if err != nil {
445445
return nil, fmt.Errorf("serveHTTPApi: socket activation failed: %s", err)
446446
}
@@ -580,7 +580,7 @@ func serveHTTPGateway(req *cmds.Request, cctx *oldcmds.Context) (<-chan error, e
580580
writable = cfg.Gateway.Writable
581581
}
582582

583-
listeners, err := sockets.TakeSockets("io.ipfs.gateway")
583+
listeners, err := sockets.TakeListeners("io.ipfs.gateway")
584584
if err != nil {
585585
return nil, fmt.Errorf("serveHTTPGateway: socket activation failed: %s", err)
586586
}

cmd/ipfs/sockets/sockets.go

Lines changed: 0 additions & 12 deletions
This file was deleted.

cmd/ipfs/sockets/sockets_linux.go

Lines changed: 0 additions & 57 deletions
This file was deleted.

go.mod

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,12 +80,13 @@ require (
8080
github.com/libp2p/go-libp2p-tls v0.1.0
8181
github.com/libp2p/go-libp2p-yamux v0.2.1
8282
github.com/libp2p/go-maddr-filter v0.0.5
83+
github.com/libp2p/go-socket-activation v0.0.1
8384
github.com/mattn/go-runewidth v0.0.4 // indirect
8485
github.com/mitchellh/go-homedir v1.1.0
8586
github.com/mr-tron/base58 v1.1.2
86-
github.com/multiformats/go-multiaddr v0.0.4
87+
github.com/multiformats/go-multiaddr v0.1.0
8788
github.com/multiformats/go-multiaddr-dns v0.0.3
88-
github.com/multiformats/go-multiaddr-net v0.0.1
89+
github.com/multiformats/go-multiaddr-net v0.1.0
8990
github.com/multiformats/go-multibase v0.0.1
9091
github.com/multiformats/go-multihash v0.0.7
9192
github.com/opentracing/opentracing-go v1.1.0

go.sum

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -452,6 +452,8 @@ github.com/libp2p/go-reuseport v0.0.1/go.mod h1:jn6RmB1ufnQwl0Q1f+YxAj8isJgDCQza
452452
github.com/libp2p/go-reuseport-transport v0.0.1/go.mod h1:YkbSDrvjUVDL6b8XqriyA20obEtsW9BLkuOUyQAOCbs=
453453
github.com/libp2p/go-reuseport-transport v0.0.2 h1:WglMwyXyBu61CMkjCCtnmqNqnjib0GIEjMiHTwR/KN4=
454454
github.com/libp2p/go-reuseport-transport v0.0.2/go.mod h1:YkbSDrvjUVDL6b8XqriyA20obEtsW9BLkuOUyQAOCbs=
455+
github.com/libp2p/go-socket-activation v0.0.1 h1:X6cbwufPOVAO4RufEDz6rEl9AG1ZKf+bKpyDCUIHdU4=
456+
github.com/libp2p/go-socket-activation v0.0.1/go.mod h1:oLhRjibR6AmNIazrF5xRMJTi/Fv1UEcbHCqiWqxBcUs=
455457
github.com/libp2p/go-stream-muxer v0.0.1/go.mod h1:bAo8x7YkSpadMTbtTaxGVHWUQsR/l5MEaHbKaliuT14=
456458
github.com/libp2p/go-stream-muxer v0.1.0/go.mod h1:8JAVsjeRBCWwPoZeH0W1imLOcriqXJyFvB0mR4A04sQ=
457459
github.com/libp2p/go-stream-muxer-multistream v0.1.1/go.mod h1:zmGdfkQ1AzOECIAcccoL8L//laqawOsO03zX8Sa+eGw=
@@ -515,6 +517,8 @@ github.com/multiformats/go-multiaddr v0.0.1/go.mod h1:xKVEak1K9cS1VdmPZW3LSIb6lg
515517
github.com/multiformats/go-multiaddr v0.0.2/go.mod h1:xKVEak1K9cS1VdmPZW3LSIb6lgmoS58qz/pzqmAxV44=
516518
github.com/multiformats/go-multiaddr v0.0.4 h1:WgMSI84/eRLdbptXMkMWDXPjPq7SPLIgGUVm2eroyU4=
517519
github.com/multiformats/go-multiaddr v0.0.4/go.mod h1:xKVEak1K9cS1VdmPZW3LSIb6lgmoS58qz/pzqmAxV44=
520+
github.com/multiformats/go-multiaddr v0.1.0 h1:fkISCUNDb3xIpCcI6BGlPsQE+ywcxzimOsUnHWnrE74=
521+
github.com/multiformats/go-multiaddr v0.1.0/go.mod h1:xKVEak1K9cS1VdmPZW3LSIb6lgmoS58qz/pzqmAxV44=
518522
github.com/multiformats/go-multiaddr-dns v0.0.1/go.mod h1:9kWcqw/Pj6FwxAwW38n/9403szc57zJPs45fmnznu3Q=
519523
github.com/multiformats/go-multiaddr-dns v0.0.2/go.mod h1:9kWcqw/Pj6FwxAwW38n/9403szc57zJPs45fmnznu3Q=
520524
github.com/multiformats/go-multiaddr-dns v0.0.3 h1:P19q/k9jwmtgh+qXFkKfgFM7rCg/9l5AVqh7VNxSXhs=
@@ -523,6 +527,8 @@ github.com/multiformats/go-multiaddr-fmt v0.0.1 h1:5YjeOIzbX8OTKVaN72aOzGIYW7Pnr
523527
github.com/multiformats/go-multiaddr-fmt v0.0.1/go.mod h1:aBYjqL4T/7j4Qx+R73XSv/8JsgnRFlf0w2KGLCmXl3Q=
524528
github.com/multiformats/go-multiaddr-net v0.0.1 h1:76O59E3FavvHqNg7jvzWzsPSW5JSi/ek0E4eiDVbg9g=
525529
github.com/multiformats/go-multiaddr-net v0.0.1/go.mod h1:nw6HSxNmCIQH27XPGBuX+d1tnvM7ihcFwHMSstNAVUU=
530+
github.com/multiformats/go-multiaddr-net v0.1.0 h1:ZepO8Ezwovd+7b5XPPDhQhayk1yt0AJpzQBpq9fejx4=
531+
github.com/multiformats/go-multiaddr-net v0.1.0/go.mod h1:5JNbcfBOP4dnhoZOv10JJVkJO0pCCEf8mTnipAo2UZQ=
526532
github.com/multiformats/go-multibase v0.0.1 h1:PN9/v21eLywrFWdFNsFKaU04kLJzuYzmrJR+ubhT9qA=
527533
github.com/multiformats/go-multibase v0.0.1/go.mod h1:bja2MqRZ3ggyXtZSEDKpl0uO/gviWFaSteVbWT51qgs=
528534
github.com/multiformats/go-multihash v0.0.1/go.mod h1:w/5tugSrLEbWqlcgJabL3oHFKTwfvkofsjW2Qa1ct4U=

0 commit comments

Comments
 (0)