Skip to content

Commit d273d71

Browse files
Vectorizedatarpara
andauthored
✨ Add minimal 1967 to LibClone (ethereum#633)
Co-authored-by: atarpara <[email protected]>
1 parent 9947394 commit d273d71

File tree

3 files changed

+325
-62
lines changed

3 files changed

+325
-62
lines changed

.gas-snapshot

Lines changed: 31 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ EIP712Test:testHashTypedDataOnCloneWithChaindIdChange() (gas: 49568)
125125
EIP712Test:testHashTypedDataOnDynamic() (gas: 44881)
126126
EIP712Test:testHashTypedDataOnDynamicWithChaindIdChange() (gas: 57389)
127127
EIP712Test:testHashTypedDataWithChaindIdChange() (gas: 45785)
128-
EIP712Test:test__codesize() (gas: 13856)
128+
EIP712Test:test__codesize() (gas: 13877)
129129
ERC1155HooksTest:testERC1155Hooks() (gas: 4398893)
130130
ERC1155HooksTest:test__codesize() (gas: 12083)
131131
ERC1155Test:testApproveAll(address,bool) (runs: 256, μ: 44437, ~: 38848)
@@ -492,18 +492,24 @@ LibBitmapTest:testBitmapUnsetBatch() (gas: 3086142)
492492
LibBitmapTest:testBitmapUnsetBatchAcrossMultipleBuckets() (gas: 453362)
493493
LibBitmapTest:testBitmapUnsetBatchWithinSingleBucket() (gas: 446762)
494494
LibBitmapTest:test__codesize() (gas: 8119)
495-
LibCloneTest:testClone() (gas: 72811)
496-
LibCloneTest:testClone(uint256) (runs: 256, μ: 72861, ~: 72861)
497-
LibCloneTest:testCloneDeteministicWithImmutableArgs() (gas: 193305)
498-
LibCloneTest:testCloneDeteministicWithImmutableArgs(address,uint256,uint256[],bytes,uint64,uint8,uint256) (runs: 256, μ: 1136926, ~: 1146471)
499-
LibCloneTest:testCloneDeterministic() (gas: 96604)
500-
LibCloneTest:testCloneDeterministic(uint256,bytes32) (runs: 256, μ: 96629, ~: 96629)
501-
LibCloneTest:testCloneDeterministicRevertsIfAddressAlreadyUsed() (gas: 96882825)
502-
LibCloneTest:testCloneWithImmutableArgs() (gas: 120581)
503-
LibCloneTest:testCloneWithImmutableArgs(uint256,address,uint256,uint256[],uint64,uint8) (runs: 256, μ: 981643, ~: 970078)
504-
LibCloneTest:testCloneWithImmutableArgsRevertsIfDataTooBig() (gas: 97305784)
505-
LibCloneTest:testStartsWithCaller(uint256) (runs: 256, μ: 28152, ~: 28382)
506-
LibCloneTest:test__codesize() (gas: 15743)
495+
LibCloneTest:testClone() (gas: 73099)
496+
LibCloneTest:testClone(uint256) (runs: 256, μ: 73150, ~: 73150)
497+
LibCloneTest:testCloneDeteministicWithImmutableArgs() (gas: 193587)
498+
LibCloneTest:testCloneDeteministicWithImmutableArgs(address,uint256,uint256[],bytes,uint64,uint8,uint256) (runs: 256, μ: 1137252, ~: 1146797)
499+
LibCloneTest:testCloneDeterministic() (gas: 96920)
500+
LibCloneTest:testCloneDeterministic(uint256,bytes32) (runs: 256, μ: 97012, ~: 97012)
501+
LibCloneTest:testCloneDeterministicRevertsIfAddressAlreadyUsed() (gas: 96882838)
502+
LibCloneTest:testCloneWithImmutableArgs() (gas: 120965)
503+
LibCloneTest:testCloneWithImmutableArgs(uint256,address,uint256,uint256[],uint64,uint8) (runs: 256, μ: 982027, ~: 970462)
504+
LibCloneTest:testCloneWithImmutableArgsRevertsIfDataTooBig() (gas: 97305792)
505+
LibCloneTest:testDeployDeterministicERC1967() (gas: 123287)
506+
LibCloneTest:testDeployDeterministicERC1967(uint256,bytes32) (runs: 256, μ: 123357, ~: 123357)
507+
LibCloneTest:testDeployDeterministicERC1967RevertsIfAddressAlreadyUsed() (gas: 96883656)
508+
LibCloneTest:testDeployERC1967() (gas: 99367)
509+
LibCloneTest:testDeployERC1967(uint256) (runs: 256, μ: 99418, ~: 99418)
510+
LibCloneTest:testInitialDeposit() (gas: 323861)
511+
LibCloneTest:testStartsWithCaller(uint256) (runs: 256, μ: 28162, ~: 28405)
512+
LibCloneTest:test__codesize() (gas: 17564)
507513
LibMapTest:testFoundStatementDifferential(uint256,uint256,uint256) (runs: 256, μ: 499, ~: 499)
508514
LibMapTest:testGeneralMapFunctionsGas() (gas: 3304775)
509515
LibMapTest:testGeneralMapFunctionsWithSmallBitWidths(uint256) (runs: 256, μ: 79507, ~: 83653)
@@ -706,19 +712,19 @@ LibStringTest:testToStringZeroBrutalized() (gas: 613803)
706712
LibStringTest:testToStringZeroRightPadded(uint256) (runs: 256, μ: 718269, ~: 613726)
707713
LibStringTest:test__codesize() (gas: 40236)
708714
LibZipTest:testCdCompress() (gas: 166411)
709-
LibZipTest:testCdCompressDecompress(bytes) (runs: 256, μ: 728307, ~: 648421)
710-
LibZipTest:testCdCompressDecompress(uint256) (runs: 256, μ: 812673, ~: 710419)
715+
LibZipTest:testCdCompressDecompress(bytes) (runs: 256, μ: 763819, ~: 651126)
716+
LibZipTest:testCdCompressDecompress(uint256) (runs: 256, μ: 800823, ~: 712072)
711717
LibZipTest:testCdDecompressOnInvalidInput() (gas: 34920)
712-
LibZipTest:testCdFallback() (gas: 5684253)
713-
LibZipTest:testCdFallback(bytes,uint256) (runs: 256, μ: 1226089, ~: 1043747)
714-
LibZipTest:testCdFallbackDecompressor(bytes) (runs: 256, μ: 121253, ~: 117213)
715-
LibZipTest:testCdFallbackDecompressor(uint256) (runs: 256, μ: 168196, ~: 154885)
716-
LibZipTest:testCdFallbackMaskTrick(uint256,uint256) (runs: 256, μ: 688, ~: 663)
717-
LibZipTest:testDecompressWontRevert(bytes) (runs: 256, μ: 714186, ~: 629478)
718-
LibZipTest:testFlzCompressDecompress() (gas: 2161289)
719-
LibZipTest:testFlzCompressDecompress(bytes) (runs: 256, μ: 839698, ~: 683883)
720-
LibZipTest:testFlzCompressDecompress2() (gas: 1013575)
721-
LibZipTest:test__codesize() (gas: 21730)
718+
LibZipTest:testCdFallback() (gas: 5684348)
719+
LibZipTest:testCdFallback(bytes,uint256) (runs: 256, μ: 1193207, ~: 1044365)
720+
LibZipTest:testCdFallbackDecompressor(bytes) (runs: 256, μ: 121269, ~: 117242)
721+
LibZipTest:testCdFallbackDecompressor(uint256) (runs: 256, μ: 167589, ~: 153865)
722+
LibZipTest:testCdFallbackMaskTrick(uint256,uint256) (runs: 256, μ: 686, ~: 663)
723+
LibZipTest:testDecompressWontRevert(bytes) (runs: 256, μ: 720927, ~: 630393)
724+
LibZipTest:testFlzCompressDecompress() (gas: 2162941)
725+
LibZipTest:testFlzCompressDecompress(bytes) (runs: 256, μ: 890883, ~: 687002)
726+
LibZipTest:testFlzCompressDecompress2() (gas: 1015228)
727+
LibZipTest:test__codesize() (gas: 21762)
722728
MerkleProofLibTest:testEmptyCalldataHelpers() (gas: 1086)
723729
MerkleProofLibTest:testVerifyMultiProof(bool,bool,bool,bool,bytes32) (runs: 256, μ: 750274, ~: 629029)
724730
MerkleProofLibTest:testVerifyMultiProofForHeightOneTree(bool,bool,bool,bool,bool,bool[]) (runs: 256, μ: 33429, ~: 32418)

0 commit comments

Comments
 (0)